feat(activity): harden recent activity recaps #30

Merged
pdurlej merged 1 commit from codex/activity-explain-today into codex/agent-machine-identities 2026-05-10 13:35:23 +02:00
Collaborator

Canary status: missing - fire 3+3 review before merge

Stacked on #28 (codex/agent-machine-identities). Implements #6.

Summary

Hardens get_recent_activity for recap questions: "co dziś przesunąłem?", "co dziś zrobiła Iskra?", and "co przyszło z Signala?".

Scope

  • Adds optional actorKind filter (human / agent) to Integration API and MCP.
  • Adds a small response summary with effective since, Europe/Warsaw timezone, move/human/agent/Signal counts.
  • When onlyMoves=true and no explicit action is passed, scopes agent audit to move_card so move recaps do not include unrelated create/comment audit rows.
  • Keeps timezone-offset ISO input valid and tested, including 2026-05-09T00:00:00+02:00 -> 2026-05-08T22:00:00.000Z.
  • Updates MCP description and contract docs.

Non-goals

  • No analytics dashboard.
  • No flow metrics.
  • No mutation behavior changes.
  • No production deploy.

Spec sources read

  • Issue #6
  • docs/agent-mcp-contract.md
  • docs/kan-ductor-working-pr-plan.md
  • Current MCP smoke-loop behavior around get_recent_activity

Tests / smoke

  • pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts (15 tests passed)
  • pnpm --filter @kan/api typecheck
  • pnpm --filter @kan/mcp typecheck
  • pnpm --filter @kan/db build
  • pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts packages/mcp/src/index.ts packages/mcp/src/client.ts docs/agent-mcp-contract.md
  • git diff --check

Rollback

Revert this commit. No schema changes and no data changes.

Owner gates

None expected unless the API response contract is considered breaking by an existing external client.

Canary status: missing - fire 3+3 review before merge Stacked on #28 (`codex/agent-machine-identities`). Implements #6. ## Summary Hardens `get_recent_activity` for recap questions: "co dziś przesunąłem?", "co dziś zrobiła Iskra?", and "co przyszło z Signala?". ## Scope - Adds optional `actorKind` filter (`human` / `agent`) to Integration API and MCP. - Adds a small response `summary` with effective `since`, `Europe/Warsaw` timezone, move/human/agent/Signal counts. - When `onlyMoves=true` and no explicit action is passed, scopes agent audit to `move_card` so move recaps do not include unrelated create/comment audit rows. - Keeps timezone-offset ISO input valid and tested, including `2026-05-09T00:00:00+02:00` -> `2026-05-08T22:00:00.000Z`. - Updates MCP description and contract docs. ## Non-goals - No analytics dashboard. - No flow metrics. - No mutation behavior changes. - No production deploy. ## Spec sources read - Issue #6 - `docs/agent-mcp-contract.md` - `docs/kan-ductor-working-pr-plan.md` - Current MCP smoke-loop behavior around `get_recent_activity` ## Tests / smoke - `pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts` (15 tests passed) - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/db build` - `pnpm exec prettier --check packages/api/src/routers/agent.ts packages/api/src/routers/agent.test.ts packages/mcp/src/index.ts packages/mcp/src/client.ts docs/agent-mcp-contract.md` - `git diff --check` ## Rollback Revert this commit. No schema changes and no data changes. ## Owner gates None expected unless the API response contract is considered breaking by an existing external client.
Author
Collaborator

3+3 Review Result

Status: OK with residual risk

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

  • PASS: @kan/db typecheck/build
  • PASS: @kan/shared typecheck/build
  • PASS: @kan/mcp typecheck/build
  • PASS: @kan/api typecheck/build and focused agent tests: 28/28
  • FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
  • FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

  • No 3+3 blocker found. Residual risk: recap accuracy depends on audit/card activity completeness and timezone semantics.
## 3+3 Review Result Status: **OK with residual risk** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - No 3+3 blocker found. Residual risk: recap accuracy depends on audit/card activity completeness and timezone semantics.
pdurlej merged commit 0e62a24e29 into codex/agent-machine-identities 2026-05-10 13:35:23 +02:00
Sign in to join this conversation.
No reviewers
No labels
3plus3-followup
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
analytics
api
cockpit
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
docs
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
gemini-flash
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
leviathan
mcp
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
ops
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
scout
security
size/large
size/medium
size/small
size/tiny
size/unknown
small-task
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tests
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/kan-ductor!30
No description provided.