bug(api): getRecentActivity regresses contract from PR #30 (drops actorKind/summary behavior) #56

Open
opened 2026-05-10 14:19:52 +02:00 by pdurlej · 1 comment
Owner

Source

3+3 review on PR #47 (feat: add flow health settings view), merged 2026-05-10 via chain drain #52.

"current stack regresses getRecentActivity contract from PR #30 by dropping actorKind/summary behavior"

Problem

The getRecentActivity MCP/API contract established in PR #30 included:

  • actorKind field (human / agent)
  • Summary behavior for natural-language recap answers ("co dziś przesunęłam?", "co dziś zrobiła Iskra?")

Current chain stack (after PR #47 + flow health settings) regressed these — Iskra cannot reliably answer recap queries with proper actor attribution.

Scope

  • Restore actorKind field in getRecentActivity output
  • Restore summary-friendly shape (per docs/agent-mcp-contract.md "Activity And Audit Attribution" section)
  • Verify against issue #6 acceptance criteria (activity/explain-what-changed-today)
  • Add regression test: assert PR #30 contract fields present in output

Acceptance criteria

  • getRecentActivity returns actorKind for each activity row
  • Iskra MCP recap queries produce proper "Piotr / OpenClaw Iskra MCP" attribution
  • Test asserts contract shape stays present across future changes

Refs

  • PR #47 (chain drain via #52)
  • PR #30 (original contract)
  • Issue #6 (activity/explain-what-changed-today)
  • 3+3 review comment id 3195
## Source 3+3 review on PR #47 (`feat: add flow health settings view`), merged 2026-05-10 via chain drain #52. > "current stack regresses getRecentActivity contract from PR #30 by dropping actorKind/summary behavior" ## Problem The `getRecentActivity` MCP/API contract established in PR #30 included: - `actorKind` field (`human` / `agent`) - Summary behavior for natural-language recap answers ("co dziś przesunęłam?", "co dziś zrobiła Iskra?") Current chain stack (after PR #47 + flow health settings) regressed these — Iskra cannot reliably answer recap queries with proper actor attribution. ## Scope - Restore `actorKind` field in `getRecentActivity` output - Restore summary-friendly shape (per `docs/agent-mcp-contract.md` "Activity And Audit Attribution" section) - Verify against issue #6 acceptance criteria (`activity/explain-what-changed-today`) - Add regression test: assert PR #30 contract fields present in output ## Acceptance criteria - `getRecentActivity` returns `actorKind` for each activity row - Iskra MCP recap queries produce proper "Piotr / OpenClaw Iskra MCP" attribution - Test asserts contract shape stays present across future changes ## Refs - PR #47 (chain drain via #52) - PR #30 (original contract) - Issue #6 (`activity/explain-what-changed-today`) - 3+3 review comment id 3195
Collaborator

{
"confidence": 5,
"effort_hint": "small",
"escalation": {
"kind": "none",
"reason": ""
},
"evidence_refs": [
{
"note": "Issue reports getRecentActivity regressing actorKind and summary-friendly behavior from an earlier contract.",
"type": "forgejo",
"value": "issue-title-body-labels-and-target-snapshot"
},
{
"note": "Body states missing actor attribution prevents reliable natural-language recap answers.",
"type": "forgejo",
"value": "issue-body-problem"
},
{
"note": "Scope restores actorKind, summary-friendly shape, and adds regression tests against the prior contract.",
"type": "forgejo",
"value": "issue-body-scope"
}
],
"impact": 4,
"judge_actor": {
"name": "iskra",
"runtime": "openclaw"
},
"judged_at": "2026-06-09T01:08:00Z",
"labels_to_apply": [
"judge/p1",
"judge/codex-candidate"
],
"piotr_fit": "high",
"priority": "p1",
"rationale_summary": "This is P1 Codex-ready regression work because activity attribution is core to reliable Kan-ductor recap answers and operator trust.",
"reach": 4,
"recommended_next_action": "codex_candidate",
"rerun_reason": "no_prior_judgment",
"schema": "openclaw.judge.v0",
"target": {
"kind": "issue",
"number": 56,
"repo": "pdurlej/kan-ductor"
},
"target_snapshot": {
"body_hash": "sha256:dfca2f002cac58f4f21c8aa53ef23aac9aa704c4388e116f53b2e01d7f8e9dfa",
"commit_count": null,
"evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
"head_sha": null,
"labels": [
"3plus3-followup",
"priority:p1"
],
"labels_hash": "sha256:eae246ad0747d73dd2fb96aea169d7d74574e5b2de03312edce7ec9f6d87a8f0",
"state": "open",
"title_hash": "sha256:c0c2989ec8ac7c130e477cf366e18651bf823456c82e86d257831cf757db831b",
"updated_at": "2026-05-28T01:20:39+02:00"
},
"top_caveat": "Keep the fix read-only and contract-focused; do not expand into flow analytics or mutation scope."
}

<!-- openclaw.judge.v0 --> { "confidence": 5, "effort_hint": "small", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue reports getRecentActivity regressing actorKind and summary-friendly behavior from an earlier contract.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body states missing actor attribution prevents reliable natural-language recap answers.", "type": "forgejo", "value": "issue-body-problem" }, { "note": "Scope restores actorKind, summary-friendly shape, and adds regression tests against the prior contract.", "type": "forgejo", "value": "issue-body-scope" } ], "impact": 4, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-09T01:08:00Z", "labels_to_apply": [ "judge/p1", "judge/codex-candidate" ], "piotr_fit": "high", "priority": "p1", "rationale_summary": "This is P1 Codex-ready regression work because activity attribution is core to reliable Kan-ductor recap answers and operator trust.", "reach": 4, "recommended_next_action": "codex_candidate", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 56, "repo": "pdurlej/kan-ductor" }, "target_snapshot": { "body_hash": "sha256:dfca2f002cac58f4f21c8aa53ef23aac9aa704c4388e116f53b2e01d7f8e9dfa", "commit_count": null, "evidence_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "head_sha": null, "labels": [ "3plus3-followup", "priority:p1" ], "labels_hash": "sha256:eae246ad0747d73dd2fb96aea169d7d74574e5b2de03312edce7ec9f6d87a8f0", "state": "open", "title_hash": "sha256:c0c2989ec8ac7c130e477cf366e18651bf823456c82e86d257831cf757db831b", "updated_at": "2026-05-28T01:20:39+02:00" }, "top_caveat": "Keep the fix read-only and contract-focused; do not expand into flow analytics or mutation scope." } <!-- /openclaw.judge.v0 -->
Sign in to join this conversation.
No labels
3plus3-followup
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
analytics
api
cockpit
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
docs
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
gemini-flash
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
leviathan
mcp
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
ops
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
scout
security
size/large
size/medium
size/small
size/tiny
size/unknown
small-task
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tests
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
ui
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/kan-ductor#56
No description provided.