fix(web): silence unused isAdmin prop in ActivityList #51

Merged

pdurlej merged 1 commit from claude/fix-activitylist-unused-isadmin into main

2026-05-10 14:10:15 +02:00

pdurlej commented

2026-05-10 13:54:50 +02:00

Owner

Scope

Single-line fix in apps/web/src/views/card/components/ActivityList.tsx: rename destructured local isAdmin → _isAdmin so the project's @typescript-eslint/no-unused-vars rule (with varsIgnorePattern: "^_") stops flagging it.

Why

The 3+3 review canary fails on 8 stacked PRs (#37, #39, #40, #41, #43, #46, #47, #50) plus #31/#32 stack tip with the same ESLint error:

apps/web/src/views/card/components/ActivityList.tsx:374 unused 'isAdmin'

The prop is destructured but never used in the component body. The caller (apps/web/src/views/card/index.tsx) does pass isAdmin={workspace.role === "admin"}, so the prop API is load-bearing for future use — we should not delete the type, only silence the destructure.

Change

 const ActivityList = ({
   cardPublicId,
   isLoading: cardIsLoading,
-  isAdmin,
+  isAdmin: _isAdmin,
   isViewOnly,
 }: {

The TypeScript prop type stays isAdmin?: boolean; — caller-facing API unchanged. Local var renamed to _isAdmin per project ESLint convention for intentionally-unused destructured names.

Tests / smoke

Run pnpm --filter @kan/web lint -- apps/web/src/views/card/components/ActivityList.tsx after merge — expected: clean.
Visual: ActivityList unchanged (no behavior, no UI).

Rollback

git revert 4b5b6a2. One-liner, zero risk.

Effect on stacked PRs

Once merged to main, the chain (#31, #32, #33, …, #50) can Update branch and the canary ESLint blocker disappears for all of them. Each PR's other per-PR review notes (product/tech blockers cited individually) are out of scope here — those need per-PR follow-ups.

Owner gate

None. Single-line typing convention fix.

Identity discipline note

This PR is the first commit authored as Claude (id 3) rather than pdurlej — operator surfaced PAT location (security find-internet-password -s git.pdurlej.com -a claude). §7 of pdurlej/agent-souls#35 (cousin identity discipline) finally honored from this side. Previous commits today / yesterday under pdurlej should be tracked as a follow-up issue (re-attribution or just discipline going forward).

— Prof Opus 🦍🎓 (war-room continuation, Codex tokens out until 2026-05-12 00:38)

## Scope Single-line fix in `apps/web/src/views/card/components/ActivityList.tsx`: rename destructured local `isAdmin` → `_isAdmin` so the project's `@typescript-eslint/no-unused-vars` rule (with `varsIgnorePattern: "^_"`) stops flagging it. ## Why The 3+3 review canary fails on **8 stacked PRs** (`#37, #39, #40, #41, #43, #46, #47, #50`) plus #31/#32 stack tip with the same ESLint error: ``` apps/web/src/views/card/components/ActivityList.tsx:374 unused 'isAdmin' ``` The prop is destructured but never used in the component body. The caller (`apps/web/src/views/card/index.tsx`) does pass `isAdmin={workspace.role === "admin"}`, so the prop API is load-bearing for future use — we should not delete the type, only silence the destructure. ## Change ```diff const ActivityList = ({ cardPublicId, isLoading: cardIsLoading, - isAdmin, + isAdmin: _isAdmin, isViewOnly, }: { ``` The TypeScript prop type stays `isAdmin?: boolean;` — caller-facing API unchanged. Local var renamed to `_isAdmin` per project ESLint convention for intentionally-unused destructured names. ## Tests / smoke - Run `pnpm --filter @kan/web lint -- apps/web/src/views/card/components/ActivityList.tsx` after merge — expected: clean. - Visual: ActivityList unchanged (no behavior, no UI). ## Rollback `git revert 4b5b6a2`. One-liner, zero risk. ## Effect on stacked PRs Once merged to `main`, the chain (`#31, #32, #33, …, #50`) can `Update branch` and the canary ESLint blocker disappears for all of them. Each PR's other per-PR review notes (product/tech blockers cited individually) are out of scope here — those need per-PR follow-ups. ## Owner gate None. Single-line typing convention fix. ## Identity discipline note This PR is the **first commit authored as `Claude` (id 3)** rather than `pdurlej` — operator surfaced PAT location (`security find-internet-password -s git.pdurlej.com -a claude`). §7 of `pdurlej/agent-souls#35` (cousin identity discipline) finally honored from this side. Previous commits today / yesterday under `pdurlej` should be tracked as a follow-up issue (re-attribution or just discipline going forward). — Prof Opus 🦍🎓 (war-room continuation, Codex tokens out until 2026-05-12 00:38)

pdurlej added 1 commit

2026-05-10 13:54:50 +02:00

fix(web): silence unused isAdmin prop in ActivityList

Forgejo CI / verify (pull_request) Successful in 10m17s

Details

Forgejo Docker Images / build (pull_request) Failing after 6s

Details

4b5b6a2fa4

The `isAdmin` prop is destructured from props but never used in the
component body. Caller (`apps/web/src/views/card/index.tsx`) still
passes `isAdmin={workspace.role === "admin"}` so the prop API is
load-bearing for some future use.

Rename the destructured local from `isAdmin` to `_isAdmin` so the
project's ESLint rule (`@typescript-eslint/no-unused-vars` with
`varsIgnorePattern: "^_"`) accepts it. The TypeScript prop type
remains `isAdmin?: boolean;` — caller-facing API unchanged.

This unblocks 3+3 review canary check on PRs #37, #39, #40, #41, #43,
#46, #47, #50 (and #31, #32 stack tip), all of which fail the same
ESLint error: `apps/web/src/views/card/components/ActivityList.tsx:374
unused 'isAdmin'`.

Refs: 3+3 review comments on PR #37, #39, #40, #41, #43, #46, #47, #50