feat(cards): add lightweight relations #34

Merged

pdurlej merged 1 commit from codex/cards-lightweight-relations into codex/web-agent-proposals-inbox

2026-05-10 13:44:23 +02:00

codex commented

2026-05-10 00:28:00 +02:00

Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Adds the board-maturity foundation for lightweight card relations: blockers, related cards, and duplicates.

Closes #10.

Scope

Add card_relation_type enum: blocks, relates_to, duplicates.
Add soft-deleteable card_relation table with public IDs, source/target cards, timestamps, and actor fields.
Add partial unique index for active source/target/type relations.
Add repository functions for create/list/get/soft-delete.
Add card API routes: listRelations, linkRelation, unlinkRelation.
Expose reverse blockedBy view for incoming blocks relations without storing a second relation.
Enforce same-workspace relation boundary and card:view/card:edit permissions.
Add integration tests for blockers, related/duplicate links, unlink, idempotent relink, and cross-workspace rejection.

Non-goals

No full dependency graph UI.
No MCP relation tools yet; that is issue #11.
No automatic scheduling, priority, or movement behavior.
No production DB migration run in this PR.

Spec sources read

docs/kan-ductor-working-pr-plan.md
Issue #10 acceptance criteria
Existing card schema/repository/router patterns
Existing PGlite integration test setup

Tests / smoke

pnpm --filter @kan/db build
pnpm --filter @kan/db typecheck
pnpm --filter @kan/api build
pnpm --filter @kan/api typecheck
pnpm --filter @kan/mcp typecheck
pnpm --filter @kan/api test -- integration-tests/card-relations.integration.test.ts
pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts
pnpm exec prettier --check packages/db/src/schema/cards.ts packages/db/src/repository/cardRelation.repo.ts packages/api/src/routers/card.ts packages/api/integration-tests/card-relations.integration.test.ts packages/db/migrations/meta/_journal.json
git diff --check

Note: Prettier cannot infer a parser for standalone .sql files in this repo, so the SQL migration was reviewed manually and exercised through PGlite migration tests.

Rollback

Revert commit 56d4ba9. If the migration has been applied in an environment, leave the table in place or run an explicit rollback migration after owner approval; this PR does not run production migrations.

Owner gates

3+3 review before merge.
Piotr approval before merge.
Owner approval before migrating production DB.

Canary status: missing — fire 3+3 review before merge ## Summary Adds the board-maturity foundation for lightweight card relations: blockers, related cards, and duplicates. Closes #10. ## Scope - Add `card_relation_type` enum: `blocks`, `relates_to`, `duplicates`. - Add soft-deleteable `card_relation` table with public IDs, source/target cards, timestamps, and actor fields. - Add partial unique index for active source/target/type relations. - Add repository functions for create/list/get/soft-delete. - Add card API routes: `listRelations`, `linkRelation`, `unlinkRelation`. - Expose reverse `blockedBy` view for incoming `blocks` relations without storing a second relation. - Enforce same-workspace relation boundary and `card:view`/`card:edit` permissions. - Add integration tests for blockers, related/duplicate links, unlink, idempotent relink, and cross-workspace rejection. ## Non-goals - No full dependency graph UI. - No MCP relation tools yet; that is issue #11. - No automatic scheduling, priority, or movement behavior. - No production DB migration run in this PR. ## Spec sources read - `docs/kan-ductor-working-pr-plan.md` - Issue #10 acceptance criteria - Existing card schema/repository/router patterns - Existing PGlite integration test setup ## Tests / smoke - `pnpm --filter @kan/db build` - `pnpm --filter @kan/db typecheck` - `pnpm --filter @kan/api build` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/api test -- integration-tests/card-relations.integration.test.ts` - `pnpm --filter @kan/api test -- agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts` - `pnpm exec prettier --check packages/db/src/schema/cards.ts packages/db/src/repository/cardRelation.repo.ts packages/api/src/routers/card.ts packages/api/integration-tests/card-relations.integration.test.ts packages/db/migrations/meta/_journal.json` - `git diff --check` Note: Prettier cannot infer a parser for standalone `.sql` files in this repo, so the SQL migration was reviewed manually and exercised through PGlite migration tests. ## Rollback Revert commit `56d4ba9`. If the migration has been applied in an environment, leave the table in place or run an explicit rollback migration after owner approval; this PR does not run production migrations. ## Owner gates - 3+3 review before merge. - Piotr approval before merge. - Owner approval before migrating production DB.

codex added 1 commit

2026-05-10 00:28:00 +02:00

feat(cards): add lightweight relations 56d4ba9ac9

codex referenced this pull request

2026-05-10 00:29:38 +02:00

cards/lightweight-relations #10

codex referenced this pull request

2026-05-10 00:37:01 +02:00

feat(mcp): expose card relation tools #35

codex commented

2026-05-10 08:48:12 +02:00

Author

Collaborator

3+3 Review Result

Status: NOT READY

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

PASS: @kan/db typecheck/build
PASS: @kan/shared typecheck/build
PASS: @kan/mcp typecheck/build
PASS: @kan/api typecheck/build and focused agent tests: 28/28
FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

Tech blocker: card relation link/unlink changes card state without card_activity records, weakening audit/history expectations. Add activity events or explicitly adjust the activity contract before merge.

## 3+3 Review Result Status: **NOT READY** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - Tech blocker: card relation link/unlink changes card state without card_activity records, weakening audit/history expectations. Add activity events or explicitly adjust the activity contract before merge.