feat(columns): add policies and wip limits #36

Merged

pdurlej merged 1 commit from codex/columns-policies-and-wip into codex/mcp-card-relations-tools

2026-05-10 13:44:35 +02:00

codex commented

2026-05-10 00:46:39 +02:00

Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

Add lightweight operating policy and advisory WIP fields to Kan-ductor columns/lists.

Scope

Add nullable list fields: policyNote, entryPolicy, exitPolicy, wipLimit, agentMovePolicy.
Add list_agent_move_policy enum: allow, warn, proposal_required.
Extend list update API to set/clear policy fields and WIP limit.
Return policy fields from board/list/card/agent read paths so MCP can consume them later.
Preserve existing behavior when policy data is absent.
Document the policy/WIP contract.

Non-goals

No hard WIP enforcement.
No workflow engine.
No policy-aware MCP warnings yet; that is the next PR.
No UI policy popover/badges yet.

Spec sources read

Forgejo issue #12: columns/policies-and-wip.
docs/kan-ductor-working-pr-plan.md Wave 2 policy plan.
Existing list/board/card read paths and output schemas.
Existing PGlite migration style with --> statement-breakpoint.

Tests / smoke

pnpm --filter @kan/db build
pnpm --filter @kan/api build
pnpm --filter @kan/api typecheck
pnpm --filter @kan/db typecheck
pnpm --filter @kan/mcp typecheck
pnpm --filter @kan/api test -- integration-tests/list-policies.integration.test.ts agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts
pnpm exec prettier --check ...touched non-SQL files
git diff --check

Rollback

Before production migration: revert the migration/code. After production migration: hide/ignore nullable policy fields and leave data in place; no hard enforcement depends on them.

Owner gates

Piotr approval required before applying the DB migration in production.

Closes #12

Canary status: missing — fire 3+3 review before merge ## Summary Add lightweight operating policy and advisory WIP fields to Kan-ductor columns/lists. ## Scope - Add nullable list fields: `policyNote`, `entryPolicy`, `exitPolicy`, `wipLimit`, `agentMovePolicy`. - Add `list_agent_move_policy` enum: `allow`, `warn`, `proposal_required`. - Extend list update API to set/clear policy fields and WIP limit. - Return policy fields from board/list/card/agent read paths so MCP can consume them later. - Preserve existing behavior when policy data is absent. - Document the policy/WIP contract. ## Non-goals - No hard WIP enforcement. - No workflow engine. - No policy-aware MCP warnings yet; that is the next PR. - No UI policy popover/badges yet. ## Spec sources read - Forgejo issue #12: `columns/policies-and-wip`. - `docs/kan-ductor-working-pr-plan.md` Wave 2 policy plan. - Existing list/board/card read paths and output schemas. - Existing PGlite migration style with `--> statement-breakpoint`. ## Tests / smoke - `pnpm --filter @kan/db build` - `pnpm --filter @kan/api build` - `pnpm --filter @kan/api typecheck` - `pnpm --filter @kan/db typecheck` - `pnpm --filter @kan/mcp typecheck` - `pnpm --filter @kan/api test -- integration-tests/list-policies.integration.test.ts agent.test.ts integration-tests/agent.integration.test.ts integration-tests/card-relations.integration.test.ts` - `pnpm exec prettier --check ...touched non-SQL files` - `git diff --check` ## Rollback Before production migration: revert the migration/code. After production migration: hide/ignore nullable policy fields and leave data in place; no hard enforcement depends on them. ## Owner gates Piotr approval required before applying the DB migration in production. Closes #12

codex added 1 commit

2026-05-10 00:46:39 +02:00

feat(columns): add policies and wip limits b8f6602005

codex referenced this pull request

2026-05-10 00:48:30 +02:00

columns/policies-and-wip #12

codex commented

2026-05-10 08:48:13 +02:00

Author

Collaborator

3+3 Review Result

Status: OK with residual risk

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

PASS: @kan/db typecheck/build
PASS: @kan/shared typecheck/build
PASS: @kan/mcp typecheck/build
PASS: @kan/api typecheck/build and focused agent tests: 28/28
FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

No 3+3 blocker found. Residual risk: WIP/policy fields are advisory only; keep UI/API language clear that there is no hard enforcement yet.

## 3+3 Review Result Status: **OK with residual risk** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - No 3+3 blocker found. Residual risk: WIP/policy fields are advisory only; keep UI/API language clear that there is no hard enforcement yet.