feat(activity): add created-list backfill script #44

Merged
pdurlej merged 1 commit from codex/activity-backfill-created-list into codex/web-machine-activity-audit-view 2026-05-10 13:47:41 +02:00
Collaborator

Canary status: missing — fire 3+3 review before merge

Summary

  • Adds scripts/backfill-card-created-list.mjs to repair historical card.created rows missing toListId.
  • Defaults to dry-run and emits JSON summaries/samples before any write.
  • Applies only safe inferences: first later move fromListId, or current list when no later move exists.
  • Reports uncertain rows as uncertain_missing_first_move_from_list without updating them.

Scope

  • Explicit operator-run data correction script.
  • Documentation in the MCP/audit contract and working PR plan.
  • No automatic migration, no production execution.

Non-goals

  • No analytics dashboard.
  • No destructive rewrites.
  • No attempt to guess uncertain initial columns.

Spec sources read

  • packages/db/src/schema/cards.ts card activity schema.
  • Current create-card activity writers in card.repo.ts, board.repo.ts, and import routes.
  • docs/agent-mcp-contract.md activity contract.

Tests / smoke

  • node --check scripts/backfill-card-created-list.mjs
  • node scripts/backfill-card-created-list.mjs --help
  • node scripts/backfill-card-created-list.mjs without POSTGRES_URL exits 1 and refuses local fallback DB.
  • pnpm exec prettier --check scripts/backfill-card-created-list.mjs docs/agent-mcp-contract.md docs/kan-ductor-working-pr-plan.md
  • git diff --check

Rollback

  • Revert commit b49453a; no database rows are changed by merging this PR alone.

Owner gates

  • Running --apply against production is an explicit owner-gated data correction.
Canary status: missing — fire 3+3 review before merge ## Summary - Adds `scripts/backfill-card-created-list.mjs` to repair historical `card.created` rows missing `toListId`. - Defaults to dry-run and emits JSON summaries/samples before any write. - Applies only safe inferences: first later move `fromListId`, or current list when no later move exists. - Reports uncertain rows as `uncertain_missing_first_move_from_list` without updating them. ## Scope - Explicit operator-run data correction script. - Documentation in the MCP/audit contract and working PR plan. - No automatic migration, no production execution. ## Non-goals - No analytics dashboard. - No destructive rewrites. - No attempt to guess uncertain initial columns. ## Spec sources read - `packages/db/src/schema/cards.ts` card activity schema. - Current create-card activity writers in `card.repo.ts`, `board.repo.ts`, and import routes. - `docs/agent-mcp-contract.md` activity contract. ## Tests / smoke - `node --check scripts/backfill-card-created-list.mjs` - `node scripts/backfill-card-created-list.mjs --help` - `node scripts/backfill-card-created-list.mjs` without `POSTGRES_URL` exits 1 and refuses local fallback DB. - `pnpm exec prettier --check scripts/backfill-card-created-list.mjs docs/agent-mcp-contract.md docs/kan-ductor-working-pr-plan.md` - `git diff --check` ## Rollback - Revert commit `b49453a`; no database rows are changed by merging this PR alone. ## Owner gates - Running `--apply` against production is an explicit owner-gated data correction.
Author
Collaborator

3+3 Review Result

Status: OK with residual risk

Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus.

Deterministic checks on current stack tip:

  • PASS: @kan/db typecheck/build
  • PASS: @kan/shared typecheck/build
  • PASS: @kan/mcp typecheck/build
  • PASS: @kan/api typecheck/build and focused agent tests: 28/28
  • FAIL: targeted web ESLint currently reports apps/web/src/views/card/components/ActivityList.tsx:374 unused isAdmin
  • FAIL, known broader baseline: @kan/web typecheck still has existing bootstrap/workspace typing errors

Canary gate: current automated canary is not green for the draft stack; treat this as a review/checkpoint result, not merge approval.

Review notes:

  • No 3+3 blocker found. Residual risk: backfill is owner-gated and dry-run-first, but production apply should preserve output and ideally use board/workspace filters.
## 3+3 Review Result Status: **OK with residual risk** Review lanes completed: tech-ollama-1, tech-ollama-2, tech-codex, product-ollama-1, product-ollama-2, product-claude-opus. Deterministic checks on current stack tip: - PASS: `@kan/db` typecheck/build - PASS: `@kan/shared` typecheck/build - PASS: `@kan/mcp` typecheck/build - PASS: `@kan/api` typecheck/build and focused agent tests: 28/28 - FAIL: targeted web ESLint currently reports `apps/web/src/views/card/components/ActivityList.tsx:374` unused `isAdmin` - FAIL, known broader baseline: `@kan/web typecheck` still has existing bootstrap/workspace typing errors Canary gate: current automated canary is **not green** for the draft stack; treat this as a review/checkpoint result, not merge approval. Review notes: - No 3+3 blocker found. Residual risk: backfill is owner-gated and dry-run-first, but production apply should preserve output and ideally use board/workspace filters.
pdurlej merged commit aa5f182b14 into codex/web-machine-activity-audit-view 2026-05-10 13:47:41 +02:00
Sign in to join this conversation.
No reviewers
No labels
3plus3-followup
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
analytics
api
cockpit
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
docs
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
gemini-flash
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
leviathan
mcp
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
ops
priority:p0
priority:p1
priority:p2
priority:p3
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
scout
security
size/large
size/medium
size/small
size/tiny
size/unknown
small-task
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tests
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
ui
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/kan-ductor!44
No description provided.