bezpieczenstwo wywajbowanego kodu #67

Closed
opened 2026-06-06 17:58:24 +02:00 by pdurlej · 3 comments
Owner

Do wdrożenia u nas, jako też lepsze zabezpieczenie bezpieczeństwa, jako dependencja czy moduł https://github.com/trynullsec/nullsec-s1

Do wdrożenia u nas, jako też lepsze zabezpieczenie bezpieczeństwa, jako dependencja czy moduł https://github.com/trynullsec/nullsec-s1
Collaborator

Triage (claude, 2026-06-08) — research via subagent

What nullsec-s1 is: open-source security-specialized LLM for auditing AI-generated/"vibecoded" code across 16 vuln categories. Fine-tuned PEFT/QLoRA adapter over Qwen2.5-Coder-7B-Instruct, Python ~93% + TS CLI. Returns structured JSON verdicts (finding/severity/exploit/fix). ~232★, active (v1.1/RC ~2026-05-31). License: Apache-2.0 → clean match with ours.

⚠️ Note for triage: the issue link author org (trynullsec) == the repo org, so treat as a self/affiliated suggestion — evaluate on merits.

How it would fit (without breaking our rules):

  • NOT a Python runtime dep (would break stdlib-only).
  • M2-compatible path = CI-workflow subprocess calling the TS CLI: npx @s1-clm/s1 scan . --json --output nullsec-report.json, then Patchwarden consumes the JSON into the existing --findings-file channel — exactly the pyfallow/Option-D pattern.
  • The CLI defaults to a hosted backend (https://s1.trynullsec.com/api); self-hosting needs GPU/VRAM.

Two real caveats before adoption:

  1. D20 sensor-not-gate: nullsec's --fail-on high is a gate (non-zero exit). We must consume findings + comment, NEVER let it block merge directly.
  2. Data egress: default backend ships code off-box to a 3rd-party API — a genuine data-governance concern for a self-hosted tool. Self-host or explicit operator opt-in required.

Fit verdict: genuinely on-mission and complementary — pyfallow = structural, Ollama = generic LLM, nullsec-s1 = security-specialized. Not redundant.

Recommendation: (a) worth a planning doc + M2 evaluation (mirror pyfallow-integration-plan.md shape). License-clean + on-mission, but the data-egress + sensor-vs-gate decisions must be deliberate, and it's a new integration → parked under M2/D21 like Luka 3. Suggest labels: kind/research, judge/p2, area:v0-core, and a flow/refining until the plan doc is written.

## Triage (claude, 2026-06-08) — research via subagent **What nullsec-s1 is:** open-source security-specialized LLM for auditing AI-generated/"vibecoded" code across 16 vuln categories. Fine-tuned PEFT/QLoRA adapter over `Qwen2.5-Coder-7B-Instruct`, Python ~93% + TS CLI. Returns structured JSON verdicts (finding/severity/exploit/fix). ~232★, active (v1.1/RC ~2026-05-31). **License: Apache-2.0** → clean match with ours. > ⚠️ Note for triage: the issue link author org (`trynullsec`) == the repo org, so treat as a self/affiliated suggestion — evaluate on merits. **How it would fit (without breaking our rules):** - ❌ NOT a Python runtime dep (would break stdlib-only). - ✅ M2-compatible path = **CI-workflow subprocess** calling the TS CLI: `npx @s1-clm/s1 scan . --json --output nullsec-report.json`, then Patchwarden consumes the JSON into the existing `--findings-file` channel — exactly the pyfallow/Option-D pattern. - The CLI defaults to a **hosted backend** (`https://s1.trynullsec.com/api`); self-hosting needs GPU/VRAM. **Two real caveats before adoption:** 1. **D20 sensor-not-gate**: nullsec's `--fail-on high` is a *gate* (non-zero exit). We must consume findings + comment, NEVER let it block merge directly. 2. **Data egress**: default backend ships code off-box to a 3rd-party API — a genuine data-governance concern for a self-hosted tool. Self-host or explicit operator opt-in required. **Fit verdict:** genuinely on-mission and *complementary* — pyfallow = structural, Ollama = generic LLM, nullsec-s1 = security-specialized. Not redundant. **Recommendation: (a) worth a planning doc + M2 evaluation** (mirror `pyfallow-integration-plan.md` shape). License-clean + on-mission, but the data-egress + sensor-vs-gate decisions must be deliberate, and it's a new integration → parked under M2/D21 like Luka 3. Suggest labels: `kind/research`, `judge/p2`, `area:v0-core`, and a `flow/refining` until the plan doc is written.
Collaborator

{
"confidence": 3,
"effort_hint": "unknown",
"escalation": {
"kind": "none",
"reason": ""
},
"evidence_refs": [
{
"note": "Issue proposes using nullsec-s1 as a dependency or module for better security.",
"type": "forgejo",
"value": "issue-title-body-labels-and-target-snapshot"
},
{
"note": "Body is currently a short security idea with an external repository link but no scoped acceptance criteria.",
"type": "forgejo",
"value": "issue-body-excerpt"
},
{
"note": "Target snapshot has no labels, so priority is inferred from sparse public issue text only.",
"type": "snapshot",
"value": "target-snapshot-labels"
}
],
"impact": 3,
"judge_actor": {
"name": "iskra",
"runtime": "openclaw"
},
"judged_at": "2026-06-09T01:03:00Z",
"labels_to_apply": [
"judge/p2",
"judge/needs-refinement"
],
"piotr_fit": "medium",
"priority": "p2",
"rationale_summary": "This is P2 but needs refinement because security hardening for generated code could matter, yet the issue lacks scope, threat model, and integration criteria.",
"reach": 3,
"recommended_next_action": "needs_refinement",
"rerun_reason": "no_prior_judgment",
"schema": "openclaw.judge.v0",
"target": {
"kind": "issue",
"number": 67,
"repo": "pdurlej/patchwarden"
},
"target_snapshot": {
"body_hash": "sha256:ded9f23a7803045353d807e53bf88893325741851885bb7f974657a158ca74c4",
"commit_count": null,
"evidence_hash": "sha256:d45bad5c07d42da443ea35491e360fe978b8d256d0d6be255198101e0d4b455f",
"head_sha": null,
"labels": [],
"labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855",
"state": "open",
"title_hash": "sha256:f0118b284b76ff3199a9e3b2451f6d17e57eca6d9551779f7545ed4a3620394a",
"updated_at": "2026-06-08T21:46:31+02:00"
},
"top_caveat": "Do not add a security dependency until its license, behavior, supply-chain risk, and concrete Patchwarden use case are reviewed."
}

<!-- openclaw.judge.v0 --> { "confidence": 3, "effort_hint": "unknown", "escalation": { "kind": "none", "reason": "" }, "evidence_refs": [ { "note": "Issue proposes using nullsec-s1 as a dependency or module for better security.", "type": "forgejo", "value": "issue-title-body-labels-and-target-snapshot" }, { "note": "Body is currently a short security idea with an external repository link but no scoped acceptance criteria.", "type": "forgejo", "value": "issue-body-excerpt" }, { "note": "Target snapshot has no labels, so priority is inferred from sparse public issue text only.", "type": "snapshot", "value": "target-snapshot-labels" } ], "impact": 3, "judge_actor": { "name": "iskra", "runtime": "openclaw" }, "judged_at": "2026-06-09T01:03:00Z", "labels_to_apply": [ "judge/p2", "judge/needs-refinement" ], "piotr_fit": "medium", "priority": "p2", "rationale_summary": "This is P2 but needs refinement because security hardening for generated code could matter, yet the issue lacks scope, threat model, and integration criteria.", "reach": 3, "recommended_next_action": "needs_refinement", "rerun_reason": "no_prior_judgment", "schema": "openclaw.judge.v0", "target": { "kind": "issue", "number": 67, "repo": "pdurlej/patchwarden" }, "target_snapshot": { "body_hash": "sha256:ded9f23a7803045353d807e53bf88893325741851885bb7f974657a158ca74c4", "commit_count": null, "evidence_hash": "sha256:d45bad5c07d42da443ea35491e360fe978b8d256d0d6be255198101e0d4b455f", "head_sha": null, "labels": [], "labels_hash": "sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855", "state": "open", "title_hash": "sha256:f0118b284b76ff3199a9e3b2451f6d17e57eca6d9551779f7545ed4a3620394a", "updated_at": "2026-06-08T21:46:31+02:00" }, "top_caveat": "Do not add a security dependency until its license, behavior, supply-chain risk, and concrete Patchwarden use case are reviewed." } <!-- /openclaw.judge.v0 -->
Collaborator

Progress in #111: added the first Patchwarden-native security slice without introducing nullsec-s1 as a dependency or sending code to a third-party backend.

What landed:

  • patchwarden.pr.security_path_sensor as an opt-in deterministic Core module;
  • blocks local secret config, credential JSON, SSH private-key, key/certificate, and secrets/ path changes before low-friction review lanes;
  • keeps the D20 split: Patchwarden emits a Contract Run module verdict only, with no repo mutation, no network, no LLM call, and no secret reading;
  • updated Core registry specs/examples, status docs, architecture docs, and PW-G002 status.

Verification: PYTHONPATH=src:. python3 -m unittest discover -s tests -> 514 tests OK. CLI smoke: .env.production blocks with patchwarden.pr.security_path_sensor; docs/.env.example passes with empty security evidence.

Boundary: this does not close #67 yet. The broader nullsec-s1/security-specialized model integration remains a separate design/evaluation item because of egress and sensor-vs-gate policy.

Progress in #111: added the first Patchwarden-native security slice without introducing `nullsec-s1` as a dependency or sending code to a third-party backend. What landed: - `patchwarden.pr.security_path_sensor` as an opt-in deterministic Core module; - blocks local secret config, credential JSON, SSH private-key, key/certificate, and `secrets/` path changes before low-friction review lanes; - keeps the D20 split: Patchwarden emits a Contract Run module verdict only, with no repo mutation, no network, no LLM call, and no secret reading; - updated Core registry specs/examples, status docs, architecture docs, and PW-G002 status. Verification: `PYTHONPATH=src:. python3 -m unittest discover -s tests` -> 514 tests OK. CLI smoke: `.env.production` blocks with `patchwarden.pr.security_path_sensor`; `docs/.env.example` passes with empty security evidence. Boundary: this does not close #67 yet. The broader nullsec-s1/security-specialized model integration remains a separate design/evaluation item because of egress and sensor-vs-gate policy.
Sign in to join this conversation.
No labels
agent/claude-code
agent/codex
agent/gemini
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
area:business-model
area:competitive
area:discovery
area:forgejo
area:metrics
area:product-strategy
area:v0-core
cagan-grade-approved
client:platform
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
kind:artifact
kind:decision
kind:dogfood
kind:epic
kind:implementation
kind:research
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
priority:p0
priority:p1
priority:p2
priority:p3
ready-for-agent
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:blocked-on-discovery
status:cagan-grade-review-pending
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:needs-operator-decision
status:operator-needed
status:parked
tier:0-anchor
tier:0-platform-substrate
tier:1-core
tier:1-iskra-value-layer
tier:2-supporting
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
wave:1-foundation
wave:2-positioning
wave:3-validation
wave:4-economics
wave:5-operating
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/patchwarden#67
No description provided.