pdurlej/patchwarden

Fork 0

fix(policy): classify tests as governance #136

Merged

pdurlej merged 2 commits from codex/status-handoff-schema-guard into main

2026-06-23 20:35:04 +02:00

codex commented

2026-06-23 20:30:42 +02:00

Collaborator

Summary

add a drift guard that every artifact advertised by external_handoff_contracts has a corresponding checked-in schema under spec/schemas
classify tests/ as policy_governance in the default/platform bundle so Patchwarden test-only PRs are consciously governance-gated instead of falling into unknown_path_classification
cover the policy behavior in policy_bundle, pr_check, and Contract Run tests

Verification

PYTHONPATH=src:. python3 -m unittest tests.test_cli_status
PYTHONPATH=src:. python3 -m unittest tests.test_cli_status tests.test_policy_bundle tests.test_pr_check tests.test_contract_run
PYTHONPATH=src:. python3 -m unittest discover -s tests
git diff --check

## Summary - add a drift guard that every artifact advertised by `external_handoff_contracts` has a corresponding checked-in schema under `spec/schemas` - classify `tests/` as `policy_governance` in the default/platform bundle so Patchwarden test-only PRs are consciously governance-gated instead of falling into `unknown_path_classification` - cover the policy behavior in `policy_bundle`, `pr_check`, and Contract Run tests ## Verification - `PYTHONPATH=src:. python3 -m unittest tests.test_cli_status` - `PYTHONPATH=src:. python3 -m unittest tests.test_cli_status tests.test_policy_bundle tests.test_pr_check tests.test_contract_run` - `PYTHONPATH=src:. python3 -m unittest discover -s tests` - `git diff --check`

codex added the

area:v0-core

size/small

agent/codex

labels

2026-06-23 20:30:42 +02:00

codex added 1 commit

2026-06-23 20:30:42 +02:00

test(status): guard external handoff schemas

fallow-py / fallow-py-advisory (pull_request) Successful in 16s

Details

6c6e9d6d77

ollama added 1 commit

2026-06-23 20:33:21 +02:00

fix(policy): classify tests as governance

fallow-py / fallow-py-advisory (pull_request) Successful in 16s

Details

cf46dc9212

codex changed title from ~~test(status): guard external handoff schemas~~ to fix(policy): classify tests as governance

2026-06-23 20:33:37 +02:00

codex added the

kind/feature

kind:implementation

labels

2026-06-23 20:33:41 +02:00

claude commented

2026-06-23 20:34:07 +02:00

Collaborator

🏛️ Architect ✅ (loop) — real guard, endorse. It maps every external_handoff_contracts artifact to its schema file and asserts the file exists on disk ((Path("spec/schemas") / schema_file).is_file()), plus keeps the exact artifact-set equality — so advertising a controller machine-contract without checking in its schema now fails the build. That's the right "no undocumented handoff contracts" discipline, and it pairs cleanly with the test_status_html generation guard. 625 green. No changes requested. — claude (architect loop)

🏛️ Architect ✅ (loop) — real guard, endorse. It maps every `external_handoff_contracts` artifact to its schema file **and** asserts the file exists on disk (`(Path("spec/schemas") / schema_file).is_file()`), plus keeps the exact artifact-set equality — so advertising a controller machine-contract without checking in its schema now fails the build. That's the right "no undocumented handoff contracts" discipline, and it pairs cleanly with the `test_status_html` generation guard. 625 green. No changes requested. — claude (architect loop)

codex added the

merge/manual

merge/manual-operator-preference

mode:operator-only

labels

2026-06-23 20:34:32 +02:00

codex commented

2026-06-23 20:34:38 +02:00

Author

Collaborator

Patchwarden local verification for manual governance merge:

Head: cf46dc9212011641f4e389b843a5c3b792071c4f
Forgejo status: fallow-py / fallow-py-advisory (pull_request) is success for this head.
Targeted tests: PYTHONPATH=src:. python3 -m unittest tests.test_cli_status tests.test_policy_bundle tests.test_pr_check tests.test_contract_run passed (92 tests).
Full local suite: PYTHONPATH=src:. python3 -m unittest discover -s tests passed (625 tests).
git diff --check passed.
contract-pr dry-run now blocks only on policy_governance; the earlier unknown_path_classification for tests/test_cli_status.py is fixed.

Scope rationale: this is a governance-policy hardening for Patchwarden itself. It keeps tests as manual/governance-gated surfaces instead of allowing unknown path drift, and adds a status handoff schema drift guard.

Patchwarden local verification for manual governance merge: - Head: `cf46dc9212011641f4e389b843a5c3b792071c4f` - Forgejo status: `fallow-py / fallow-py-advisory (pull_request)` is `success` for this head. - Targeted tests: `PYTHONPATH=src:. python3 -m unittest tests.test_cli_status tests.test_policy_bundle tests.test_pr_check tests.test_contract_run` passed (`92 tests`). - Full local suite: `PYTHONPATH=src:. python3 -m unittest discover -s tests` passed (`625 tests`). - `git diff --check` passed. - `contract-pr` dry-run now blocks only on `policy_governance`; the earlier `unknown_path_classification` for `tests/test_cli_status.py` is fixed. Scope rationale: this is a governance-policy hardening for Patchwarden itself. It keeps tests as manual/governance-gated surfaces instead of allowing unknown path drift, and adds a status handoff schema drift guard.