fix(platformctl): allow approved no-op apply #164
No reviewers
Labels
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
pdurlej/platform!164
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "codex/issues/142-apply-noop-safety"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Canary status: missing — fire canary 3+3 manually before merge
Canary Context Pack
Product story
If runtime already matches desired state, apply should finish cleanly instead of failing just because no mutation was needed.
What changed
Why it changed
The old #160 behavior made harmless in-sync plans operationally noisy while the real risk is unapproved mutation, not no-op success.
Files touched
control-plane/platformctl/apply.pycontrol-plane/platformctl/tests/test_apply_phase3.pyRelevant context
Stacked after approval-binding and plan-provenance splits.
Runtime evidence
No runtime mutation in this PR. Local tests only.
Known constraints
No-op still requires approved PR and matching clean plan source.
Explicit out-of-scope
Compose execution, status artifacts, and Actions wiring.
Requested decision
Approve safe no-op semantics.
Merge blockers
Any no-op path that bypasses approval or plan source verification.
Spec sources read
AGENTS.md— security-sensitive split rule.control-plane/platformctl/apply.py— no-op gate.control-plane/platformctl/tests/test_apply_phase3.py— tests.Refs #142
Supersedes part of #160
Ralph review (5-iter chmurowy) — ITERATE_BLOCKER 4/9
Niezależny 5-iter ralph chain. Verdict + drafted patches poniżej.
Per-dim scoring
Evidence:
~/Iskra-i-Piotr/05 System/Swarmheart Backups/ralph-phase3-apply/164/.BLOCKER 1 — Plan freshness check (TTL)
WHAT:
apply.pylines 320-333: new no-op short-circuit accepts plan jeśliexitCode == 0 && spec_changes emptyBEZ żadnej weryfikacji że plan jest current.WHY: Stale-replay attack:
PR's stated purpose ("allow approved no-op apply") expands attack surface bez time-binding.
HOW (drafted patch w
apply.pylinie 320-333):Add przed no-op short-circuit:
VERIFY (add to
tests/test_apply_phase3.py):BLOCKER 2 — Exit-code semantic hardening
WHAT:
apply.pylinia 320:plan.get("exitCode") not in (0, 1). Implicit None handling, no consistency guard betweenexitCodeandspec_changescontent.WHY: Plan z
exitCode == 0alespec_changesnon-empty (lub vice versa) reprezentuje malformed/tampered state. Current code silently accepts.HOW (drafted patch w
apply.pyprzed no-op check):Use plan.py constants instead of magic numbers:
VERIFY:
Follow-up issues
NO-OP-OBSERVABILITY-01— Structured logging + counter metricPLAN-EXIT-NONE-EXPLICIT-01— Replace implicit None checkPLAN-STATE-CROSS-TESTS-01— Cover missing plan-state combinationsAction items
apply.py+ testscodex/issues/142-apply-noop-safety— ralph batch 2026-05-10, claude-opus-4.7 (Pan Herbata) dispatching via codex identity
f8feed24b370f1c19d62Codex iteration — ralph BLOCKERs addressed
Updated branch
codex/issues/142-apply-noop-safetyat70f1c19, rebased on updated #163.Applied:
generated_at; stale or missing timestamps are rejected.exitCodeagainst change presence (0with changes and1without changes are malformed).Verification:
PYTHONPATH=control-plane pytest control-plane/platformctl/tests/test_apply_phase3.py -q→ 24 passed../tests/run-verify.shstill has the same pre-existingorigin/mainprompt debt noted on #162; not part of this PR.Filed follow-up issues:
Ready for re-review / operator review.