fix(runbooks): update 47 module runbooks to canonical RS2000 path #321

Closed

claude wants to merge 1 commit from claude/fix/runbook-canonical-paths into main

claude commented

2026-05-17 10:08:26 +02:00

Collaborator

Summary

DeepSeek-v4-Pro deep review 2026-05-14, finding #1 (CRITICAL): 47 of 80 module runbooks referenced /opt/vps-home-platform-infra/compose/apps/ as the operational compose path. Post-cutover canonical is /opt/pdurlej-platform/current/compose/apps/.

Why critical

During a 2 AM incident, operator or agent follows runbook recovery steps → compose commands fail silently (wrong path) → escalation widens → operator-attention cost multiplies. Exactly the 'agent-reads-wrong-signal' trap ADR-0018 was written to prevent, applied to human-readable recovery docs.

What

Mechanical sed batch, no semantic changes beyond path correction:

/opt/vps-home-platform-infra/compose/apps/compose.yaml → /opt/pdurlej-platform/current/compose/apps/compose.yaml
/opt/vps-home-platform-infra/compose/apps/ (cd-form) → /opt/pdurlej-platform/current/compose/apps/

47 files changed, 84/-84 lines.

Verification

$ grep -rln /opt/vps-home-platform-infra modules/*/runbook.md | wc -l
0

Zero remaining legacy references in module runbooks.

Tier

Lite per ADR-0007 (single mechanical concern, no schema/runtime/sacred-path mutation, all docs).

Out of scope (deferred)

Legacy fallback block per DeepSeek's recommendation. Adds 47 × ~5 lines of conditional prose. Defer until F4 retire decision is made — if legacy path is genuinely going to be removed in F4, fallback block becomes counter-productive noise. Operator can request follow-up if F4 timeline slips.

Refs DeepSeek deep review state/deep-reviews/2026-05-14-platform-deep-review.md finding #1, ADR-0018

## Summary DeepSeek-v4-Pro deep review 2026-05-14, finding #1 (CRITICAL): 47 of 80 module runbooks referenced `/opt/vps-home-platform-infra/compose/apps/` as the operational compose path. Post-cutover canonical is `/opt/pdurlej-platform/current/compose/apps/`. ## Why critical During a 2 AM incident, operator or agent follows runbook recovery steps → compose commands fail silently (wrong path) → escalation widens → operator-attention cost multiplies. Exactly the 'agent-reads-wrong-signal' trap ADR-0018 was written to prevent, applied to human-readable recovery docs. ## What Mechanical sed batch, no semantic changes beyond path correction: - `/opt/vps-home-platform-infra/compose/apps/compose.yaml` → `/opt/pdurlej-platform/current/compose/apps/compose.yaml` - `/opt/vps-home-platform-infra/compose/apps/` (cd-form) → `/opt/pdurlej-platform/current/compose/apps/` 47 files changed, 84/-84 lines. ## Verification ``` $ grep -rln /opt/vps-home-platform-infra modules/*/runbook.md | wc -l 0 ``` Zero remaining legacy references in module runbooks. ## Tier Lite per ADR-0007 (single mechanical concern, no schema/runtime/sacred-path mutation, all docs). ## Out of scope (deferred) Legacy fallback block per DeepSeek's recommendation. Adds 47 × ~5 lines of conditional prose. Defer until F4 retire decision is made — if legacy path is genuinely going to be removed in F4, fallback block becomes counter-productive noise. Operator can request follow-up if F4 timeline slips. Refs DeepSeek deep review `state/deep-reviews/2026-05-14-platform-deep-review.md` finding #1, ADR-0018

claude added 1 commit

2026-05-17 10:08:26 +02:00

fix(runbooks): update 47 module runbooks to canonical RS2000 path

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 3s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 23s

Details

canary-required / canary (pull_request) Successful in 15s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 22s

Details

2ae63a92af

DeepSeek deep review 2026-05-14 finding #1 (CRITICAL): 47 of 80 module
runbooks still referenced /opt/vps-home-platform-infra/compose/apps/
as the operational compose path. Post-cutover canonical path is
/opt/pdurlej-platform/current/compose/apps/.

Impact: during a 2 AM incident, operator or agent follows runbook
recovery steps → compose commands fail silently (wrong path) →
escalation widens → operator-attention cost multiplies. Exactly the
"agent-reads-wrong-signal" trap ADR-0018 was written to prevent,
applied to human-readable recovery docs.

Mechanical sed batch (no semantic changes beyond path correction):
- /opt/vps-home-platform-infra/compose/apps/compose.yaml →
  /opt/pdurlej-platform/current/compose/apps/compose.yaml (39 files)
- /opt/vps-home-platform-infra/compose/apps/ →
  /opt/pdurlej-platform/current/compose/apps/ (cd-form, 9 files,
  some overlap with above)

Verification: zero remaining legacy references in modules/*/runbook.md.

Tier: Lite per ADR-0007 (single mechanical concern, no schema/runtime/
sacred-path mutation, all docs).

Refs DeepSeek deep review 2026-05-14 finding #1

claude referenced this pull request

2026-05-17 18:25:14 +02:00

docs(specs/ddd-platform-restructure): v0 prebuild for bounded-contexts monorepo #339

codex referenced this pull request

2026-05-24 08:03:10 +02:00

fix(runbooks): use canonical compose root #405

codex commented

2026-05-24 08:03:37 +02:00

Collaborator

Fork C triage result: superseded by #405. This original PR is currently non-mergeable and is broader than needed after the RS2000 cutoff: it rewrites every /opt/vps-home-platform-infra runbook reference, including non-compose legacy/data/config/rollback references that should stay explicit. #405 is a narrower replacement that updates only operational compose command paths to /opt/pdurlej-platform/current/compose/apps and preserves intentional legacy references. Closing this PR to keep the queue clean.

codex closed this pull request

2026-05-24 08:03:37 +02:00