fix(canary): include PR body in reviewer context #449

Merged

pdurlej merged 1 commit from codex/w6/governance-plan into main

2026-05-24 21:12:45 +02:00

codex commented

2026-05-24 21:12:18 +02:00

Collaborator

Canary status: missing — rely on required Forgejo checks before merge

Canary Context Pack

Product story

Reviewer automation is only useful if reviewers see the operator intent and PR contract. Today the canary and Patchwarden paths can see the title, changed files, and diff, but not the PR body/Canary Context Pack.

What changed

canary-required.yml captures the PR body from the trusted event payload and passes it to run_review --pr-description-file.
patchwarden-pr-sanity.yml captures the PR body from the trusted event payload and passes it to pr_sanity --pr-description-file.
pr_sanity.py includes PR body in model prompts and records only descriptionPresent in JSON output, not the raw body.
W6 is marked active and W5 foundation is marked closed enough to proceed.

Why it changed

This starts W6a by addressing #85: AI reviewers should not infer intent from diff alone.

Files touched

.forgejo/workflows/canary-required.yml
.forgejo/workflows/patchwarden-pr-sanity.yml
control-plane/platformctl/ci/pr_sanity.py
control-plane/platformctl/tests/test_pr_sanity.py
state/STATUS_NOW.md
state/cycle/W5-modularity-foundation-output.md
state/cycle/W6-agent-ci-governance-output.md
state/roadmap/current-platform-roadmap.md

Relevant context

Milestone 06 / W6a CI guardrails
Issue #85
ADR-0017 no stacked PRs / branch protection context
docs/forgejo-agent-operations.md

Runtime evidence

No runtime mutation. Repo-only workflow/tooling/status update.

Known constraints

The PR body is already Forgejo PR metadata. This change does not print it into status docs or Patchwarden JSON; it only feeds it to reviewer prompts and stores the CI artifact already scoped to the PR run.

Explicit out-of-scope

No autonomous merge policy yet.
No branch-protection UI/API mutation.
No Forgejo runner or production runtime mutation.
No sensitive-path routing enforcement change yet; that remains #86/W6c.

Requested decision

Merge if required Forgejo checks are green.

Merge blockers

Workflow lint fails.
Patchwarden/canary cannot collect the PR body artifact.
pr_sanity tests fail.

Spec sources read

state/STATUS_NOW.md
state/roadmap/current-platform-roadmap.md
docs/forgejo-agent-operations.md
.forgejo/workflows/canary-required.yml
.forgejo/workflows/patchwarden-pr-sanity.yml
.forgejo/workflows/platformctl-plan.yml
.forgejo/workflows/workflow-lint.yml
control-plane/platformctl/ci/pr_sanity.py
control-plane/platformctl/tools/run_review.py
control-plane/platformctl/tools/providers/_base.py

Test plan

PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py control-plane/platformctl/tests/test_run_review.py → 50 passed
python3 control-plane/platformctl/ci/lint_workflows.py --policy .forgejo/ci-policy.yaml --workflows .forgejo/workflows --markdown /tmp/w6-workflow-lint.md --json /tmp/w6-workflow-lint.json → passed with 0 findings
git diff --check → clean

Closes #85

Canary status: missing — rely on required Forgejo checks before merge ## Canary Context Pack ### Product story Reviewer automation is only useful if reviewers see the operator intent and PR contract. Today the canary and Patchwarden paths can see the title, changed files, and diff, but not the PR body/Canary Context Pack. ### What changed - `canary-required.yml` captures the PR body from the trusted event payload and passes it to `run_review --pr-description-file`. - `patchwarden-pr-sanity.yml` captures the PR body from the trusted event payload and passes it to `pr_sanity --pr-description-file`. - `pr_sanity.py` includes PR body in model prompts and records only `descriptionPresent` in JSON output, not the raw body. - W6 is marked active and W5 foundation is marked closed enough to proceed. ### Why it changed This starts W6a by addressing #85: AI reviewers should not infer intent from diff alone. ### Files touched - `.forgejo/workflows/canary-required.yml` - `.forgejo/workflows/patchwarden-pr-sanity.yml` - `control-plane/platformctl/ci/pr_sanity.py` - `control-plane/platformctl/tests/test_pr_sanity.py` - `state/STATUS_NOW.md` - `state/cycle/W5-modularity-foundation-output.md` - `state/cycle/W6-agent-ci-governance-output.md` - `state/roadmap/current-platform-roadmap.md` ### Relevant context - Milestone 06 / W6a CI guardrails - Issue #85 - ADR-0017 no stacked PRs / branch protection context - `docs/forgejo-agent-operations.md` ### Runtime evidence No runtime mutation. Repo-only workflow/tooling/status update. ### Known constraints The PR body is already Forgejo PR metadata. This change does not print it into status docs or Patchwarden JSON; it only feeds it to reviewer prompts and stores the CI artifact already scoped to the PR run. ### Explicit out-of-scope - No autonomous merge policy yet. - No branch-protection UI/API mutation. - No Forgejo runner or production runtime mutation. - No sensitive-path routing enforcement change yet; that remains #86/W6c. ### Requested decision Merge if required Forgejo checks are green. ### Merge blockers - Workflow lint fails. - Patchwarden/canary cannot collect the PR body artifact. - `pr_sanity` tests fail. ## Spec sources read - `state/STATUS_NOW.md` - `state/roadmap/current-platform-roadmap.md` - `docs/forgejo-agent-operations.md` - `.forgejo/workflows/canary-required.yml` - `.forgejo/workflows/patchwarden-pr-sanity.yml` - `.forgejo/workflows/platformctl-plan.yml` - `.forgejo/workflows/workflow-lint.yml` - `control-plane/platformctl/ci/pr_sanity.py` - `control-plane/platformctl/tools/run_review.py` - `control-plane/platformctl/tools/providers/_base.py` ## Test plan - `PYTHONPATH=control-plane python3 -m pytest control-plane/platformctl/tests/test_pr_sanity.py control-plane/platformctl/tests/test_run_review.py` → 50 passed - `python3 control-plane/platformctl/ci/lint_workflows.py --policy .forgejo/ci-policy.yaml --workflows .forgejo/workflows --markdown /tmp/w6-workflow-lint.md --json /tmp/w6-workflow-lint.json` → passed with 0 findings - `git diff --check` → clean Closes #85

codex added 1 commit

2026-05-24 21:12:18 +02:00

fix(canary): include PR body in reviewer context

base-is-main / guard (pull_request) Successful in 1s

Details

canary-required / collect-diff (pull_request) Successful in 5s

Details

infra-docs-drift / docs-drift (pull_request) Successful in 4s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 4s

Details

python-ci / Python 3.12 (pull_request) Successful in 43s