pdurlej/platform

Fork 0

test(platformctl): cover plan state matrix #643

Merged

pdurlej merged 1 commit from codex/m06-plan-state-matrix into main

2026-05-30 16:05:02 +02:00

codex commented

2026-05-30 15:55:49 +02:00

Collaborator

Canary status: missing - fire canary 3+3 manually before merge

Canary Context Pack

Product story

Lock apply-plan state handling into a compact regression matrix so future changes do not silently loosen malformed-plan behavior.

What changed

Added a parameterized exitCode x changes matrix for 0, 1, 2, None, and bad crossed with empty, one-change, and missing changes states.
Verified accepted states remain noop or dry-run, while malformed states remain fail-closed.

Why it changed

Issue #197 asked for deterministic coverage after the explicit missing/null exitCode gate landed in #196.

Files touched

control-plane/platformctl/tests/test_apply_phase3.py

Relevant context

#197 PLAN-STATE-CROSS-TESTS-01
#196 explicit missing/null exitCode handling
M06 apply-pipeline hardening sequence

Runtime evidence

No runtime mutation. Test-only change.

Known constraints

The matrix documents existing behavior for missing changes as no-change input when exitCode=0; this PR does not introduce new plan schema enforcement.

Explicit out-of-scope

No production code changes.
No runtime apply.
No new telemetry or plan schema changes.

Requested decision

Approve and merge if checks stay green.

Merge blockers

Tests fail.
Matrix exposes nondeterministic plan state handling.
Patchwarden flags a safety regression.

Spec sources read

control-plane/platformctl/apply.py - apply-plan state behavior being covered.
control-plane/platformctl/tests/test_apply_phase3.py - existing apply-plan tests and helpers.
Forgejo issue #197 - acceptance criteria.

Validation

PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py - 99 passed
PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json - pass

Closes #197

Canary status: missing - fire canary 3+3 manually before merge ## Canary Context Pack ### Product story Lock apply-plan state handling into a compact regression matrix so future changes do not silently loosen malformed-plan behavior. ### What changed - Added a parameterized `exitCode x changes` matrix for `0`, `1`, `2`, `None`, and `bad` crossed with empty, one-change, and missing `changes` states. - Verified accepted states remain `noop` or `dry-run`, while malformed states remain fail-closed. ### Why it changed Issue #197 asked for deterministic coverage after the explicit missing/null `exitCode` gate landed in #196. ### Files touched - `control-plane/platformctl/tests/test_apply_phase3.py` ### Relevant context - #197 PLAN-STATE-CROSS-TESTS-01 - #196 explicit missing/null `exitCode` handling - M06 apply-pipeline hardening sequence ### Runtime evidence No runtime mutation. Test-only change. ### Known constraints The matrix documents existing behavior for missing `changes` as no-change input when `exitCode=0`; this PR does not introduce new plan schema enforcement. ### Explicit out-of-scope - No production code changes. - No runtime apply. - No new telemetry or plan schema changes. ### Requested decision Approve and merge if checks stay green. ### Merge blockers - Tests fail. - Matrix exposes nondeterministic plan state handling. - Patchwarden flags a safety regression. ## Spec sources read - `control-plane/platformctl/apply.py` - apply-plan state behavior being covered. - `control-plane/platformctl/tests/test_apply_phase3.py` - existing apply-plan tests and helpers. - Forgejo issue #197 - acceptance criteria. ## Validation - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m pytest control-plane/platformctl/tests/test_apply_phase3.py control-plane/platformctl/tests/test_apply_env_file.py` - 99 passed - `PYTHONPATH=control-plane control-plane/.venv/bin/python -m platformctl.cli validate all --json` - pass Closes #197

codex added 1 commit

2026-05-30 15:55:49 +02:00

test(platformctl): cover plan state matrix

canary-required / collect-diff (pull_request) Successful in 6s

Details

patchwarden-client-dry-run / collect-diff (pull_request) Successful in 5s

Details

python-ci / Python 3.12 (pull_request) Successful in 45s

Details

python-ci / Python 3.13 (pull_request) Successful in 46s

Details

base-is-main / guard (pull_request) Successful in 1s

Details

platformctl plan / auto-apply scope (pull_request) Successful in 24s

Details

pyfallow / Pyfallow gate (control-plane) (pull_request) Successful in 23s

Details

python-ci / Python 3.11 (pull_request) Successful in 46s

Details

canary-required / canary (pull_request) Successful in 15s

Details

patchwarden-client-dry-run / dry-run (pull_request) Successful in 26s

Details

patchwarden-pr-sanity / sanity (pull_request) Successful in 1m21s

Details

patchwarden-pr-sanity / collect-diff (pull_request) Successful in 5s

Details

4b8ea5b17d

codex added the

class/security-sensitive

label

2026-05-30 15:55:50 +02:00

codex commented

2026-05-30 16:02:02 +02:00

Author

Collaborator

Patchwarden PR sanity

Status: eligible_sanity_clean
PR: 643
Commit: 4b8ea5b17d92ac146c0c3af4a5ebfa3e7210646f
Security-sensitive label: present
Authority: advisory model review plus deterministic blockers only
3+3 canary: still alive; this does not replace it

Deterministic findings

No deterministic findings.

Model reviewers

`global-glm` / `glm-5.1:cloud`

Status: ok
Verdict: OK
medium Missing changes key with exitCode=0 treated as noop documents potential silent-accept gap
- Evidence: control-plane/platformctl/tests/test_apply_phase3.py line 770: (0, "missing", "noop", EXIT_NO_CHANGES, None) - when exitCode=0 and changes key is absent, plan is accepted as noop with no error
- Next: Consider a follow-up PR to enforce that exitCode=0 plans must have an explicit empty changes array (not missing key), or add schema validation that rejects plans with missing required fields. This test correctly documents current behavior but the behavior itself may warrant hardening.

`global-deepseek` / `deepseek-v4-pro:cloud`

Status: ok
Verdict: OK
Findings: none

`redteam` / `kimi-k2.6:cloud`

Status: ok
Verdict: OK
Findings: none

Policy notes

GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot.
Optional red-team model is enabled only when PLATFORMCTL_PR_SANITY_REDTEAM_MODEL is configured.
Auto-merge is not enabled here.

# Patchwarden PR sanity - Status: `eligible_sanity_clean` - PR: `643` - Commit: `4b8ea5b17d92ac146c0c3af4a5ebfa3e7210646f` - Security-sensitive label: `present` - Authority: advisory model review plus deterministic blockers only - 3+3 canary: still alive; this does not replace it ## Deterministic findings No deterministic findings. ## Model reviewers ### `global-glm` / `glm-5.1:cloud` - Status: `ok` - Verdict: `OK` - **`medium`** Missing changes key with exitCode=0 treated as noop documents potential silent-accept gap - Evidence: `control-plane/platformctl/tests/test_apply_phase3.py line 770: (0, "missing", "noop", EXIT_NO_CHANGES, None) - when exitCode=0 and changes key is absent, plan is accepted as noop with no error` - Next: Consider a follow-up PR to enforce that exitCode=0 plans must have an explicit empty changes array (not missing key), or add schema validation that rejects plans with missing required fields. This test correctly documents current behavior but the behavior itself may warrant hardening. ### `global-deepseek` / `deepseek-v4-pro:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ### `redteam` / `kimi-k2.6:cloud` - Status: `ok` - Verdict: `OK` - Findings: none ## Policy notes - GLM 5.1 + DeepSeek V4 Pro are the operator-required model mix for this bot. - Optional red-team model is enabled only when `PLATFORMCTL_PR_SANITY_REDTEAM_MODEL` is configured. - Auto-merge is not enabled here.