test(verify): cherry-pick L4-Verify suite to main (fix #123 base_ref oversight) #137

Merged

pdurlej merged 1 commit from claude/orders/cherry-pick-123-l4-verify into main

2026-05-09 23:57:31 +02:00

claude commented

2026-05-09 23:54:00 +02:00

Collaborator

Canary status: missing — Small PR class (cherry-pick of already-canary'd content from #123); operator may operator_override given context

Why this PR exists

PR #123 was opened with base_ref: codex/issues/63-validate-jsonschema (chained on #119), not main. Operator merged #123 into that chained branch 2026-05-09 23:37, but the chained branch had already been merged to main via #119 — so #123's unique deliverables (tests/test_l4_verify.py + tests/run-verify.sh) never reached main.

Codex detected this gap when starting prompts/codex-cleanup-122-124-2026-05-09.md. Packet M (#122 waiver mechanism) extends test_l4_verify.py. Codex halted Packet M on stop-condition "if PR #123 not yet merged when you start" and correctly proceeded to independent Packet N (#124 honcho-redis fix).

What this ships

Cherry-pick of 2 unique files from origin/codex/issues/66-l4-verify-suite straight to main:

tests/test_l4_verify.py (130 lines, pytest deterministic suite per Plan §L4-Verify)
tests/run-verify.sh (8-line wrapper invoking pytest with PYTHONPATH set)

Verification

python3 -m py_compile tests/test_l4_verify.py — PASS
bash -n tests/run-verify.sh — PASS
Both files originated in PR #123 which already passed canary 3+3 + python-ci 3.11/3.12/3.13 (per #123 PR check status: 'All checks were successful')

Out of scope

Token-budget waiver mechanism (Codex's Packet M)
Cross-link findings cleanup (Codex's Packet M sub-decision)
Anything else from #123 / #122 / #124 / #100

Spec sources read

PR #123 metadata + diff (verified base_ref + merged_at + content)
git log origin/main (verified absence of test_l4_verify.py, run-verify.sh)
git ls-tree origin/main -- tests/ (confirmed only smoke.sh + validate-schema.sh present)
prompts/codex-cleanup-122-124-2026-05-09.md Packet M stop-condition (matches Codex's actual behavior)

Test plan

Operator merge
After merge: Codex retries Packet M (waiver mechanism); will find tests/test_l4_verify.py on main and proceed
Codex's Packet N (#124 honcho-redis fix) continues independently in parallel

Note for next claude

This is the second modelizm-pattern catch in 4 days (per state/glm-sunset-watch.md + AGENTS.md anti-patterns). I assumed PR #123 "merged" → on main without checking base_ref. Codex caught it correctly. Symmetric disclosure obligation applies to me too — verify base_ref of every PR claimed-merged before treating it as on-main.

Canary status: missing — Small PR class (cherry-pick of already-canary'd content from #123); operator may operator_override given context ## Why this PR exists PR #123 was opened with `base_ref: codex/issues/63-validate-jsonschema` (chained on #119), not `main`. Operator merged #123 into that chained branch 2026-05-09 23:37, but the chained branch had **already been merged** to main via #119 — so #123's unique deliverables (`tests/test_l4_verify.py` + `tests/run-verify.sh`) never reached main. Codex detected this gap when starting `prompts/codex-cleanup-122-124-2026-05-09.md`. Packet M (#122 waiver mechanism) extends `test_l4_verify.py`. Codex halted Packet M on stop-condition "if PR #123 not yet merged when you start" and correctly proceeded to independent Packet N (#124 honcho-redis fix). ## What this ships Cherry-pick of 2 unique files from `origin/codex/issues/66-l4-verify-suite` straight to main: - `tests/test_l4_verify.py` (130 lines, pytest deterministic suite per Plan §L4-Verify) - `tests/run-verify.sh` (8-line wrapper invoking pytest with PYTHONPATH set) ## Verification - `python3 -m py_compile tests/test_l4_verify.py` — PASS - `bash -n tests/run-verify.sh` — PASS - Both files originated in PR #123 which already passed canary 3+3 + python-ci 3.11/3.12/3.13 (per #123 PR check status: 'All checks were successful') ## Out of scope - Token-budget waiver mechanism (Codex's Packet M) - Cross-link findings cleanup (Codex's Packet M sub-decision) - Anything else from #123 / #122 / #124 / #100 ## Spec sources read - PR #123 metadata + diff (verified base_ref + merged_at + content) - `git log origin/main` (verified absence of test_l4_verify.py, run-verify.sh) - `git ls-tree origin/main -- tests/` (confirmed only smoke.sh + validate-schema.sh present) - `prompts/codex-cleanup-122-124-2026-05-09.md` Packet M stop-condition (matches Codex's actual behavior) ## Test plan - [ ] Operator merge - [ ] After merge: Codex retries Packet M (waiver mechanism); will find `tests/test_l4_verify.py` on main and proceed - [ ] Codex's Packet N (#124 honcho-redis fix) continues independently in parallel ## Note for next claude This is the second `modelizm`-pattern catch in 4 days (per `state/glm-sunset-watch.md` + AGENTS.md anti-patterns). I assumed PR #123 "merged" → on main without checking `base_ref`. Codex caught it correctly. Symmetric disclosure obligation applies to me too — verify base_ref of every PR claimed-merged before treating it as on-main.

claude added 1 commit

2026-05-09 23:54:00 +02:00

test(verify): cherry-pick L4-Verify suite from #123 to main

canary-required / collect-diff (pull_request) Successful in 4s

Details

python-ci / Python 3.11 (pull_request) Successful in 34s

Details

python-ci / Python 3.12 (pull_request) Successful in 35s

Details

python-ci / Python 3.13 (pull_request) Successful in 34s

Details

canary-required / canary (pull_request) Successful in 12s

Details

f0116163d1

PR #123 was originally opened with base_ref = codex/issues/63-validate-jsonschema
(chained on PR #119). Operator merged #123 into that chained branch
2026-05-09 23:37, but the chained branch had already been merged to main
via #119 — so #123's unique changes (tests/test_l4_verify.py +
tests/run-verify.sh) never reached main.

Codex correctly detected this gap when starting the cleanup prompt
(prompts/codex-cleanup-122-124-2026-05-09.md, Packet M depends on
test_l4_verify.py to extend with waiver mechanism). Codex halted on
Packet M with stop-condition "if PR #123 not yet merged when you start"
and proceeded to independent Packet N.

This PR cherry-picks the 2 unique files from origin/codex/issues/66-l4-verify-suite
straight into main, unblocking Packet M.

Files:
- tests/test_l4_verify.py (130 lines, pytest deterministic suite per Plan §L4-Verify)
- tests/run-verify.sh (8-line wrapper)

Both syntax-checked: python3 -m py_compile + bash -n pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>