pdurlej/platform

Fork 0

test(verify): add l4 prompt waivers #139

Merged

pdurlej merged 1 commit from codex/issues/122-l4-waivers into main

2026-05-10 00:17:09 +02:00

codex commented

2026-05-10 00:14:39 +02:00

Collaborator

Canary status: missing — tests/prompts PR; fire canary 3+3 before merge

Canary Context Pack

Product story

L4 verify should be runnable on main without silently hiding prompt hygiene debt. Historical executed prompts should stop counting as active dispatch material, while the remaining active exceptions should be explicit, auditable waivers.

What changed

Added tests/l4-verify-waivers.yaml for explicit token-budget and cross-link waivers.
Updated tests/test_l4_verify.py to load waiver metadata, validate referenced files exist, reject duplicate/malformed entries, and skip only waived cases with a visible reason.
Archived nine executed prompts under prompts/archive/<date>/ and added prompts/archive/README.md.
Opened follow-up issue #138 for active prompt cross-link cleanup debt.

Why it changed

Issue #122 needed a waiver mechanism after PR #137 restored the L4 verify suite onto main. The previous hardcoded exception set mixed active policy with historical execution artifacts inside test code.

Files touched

tests/test_l4_verify.py
tests/l4-verify-waivers.yaml
prompts/archive/README.md
archived executed prompt files under prompts/archive/2026-04-26/, prompts/archive/2026-04-28/, prompts/archive/2026-05-03/, and prompts/archive/2026-05-04/

Relevant context

#122 token-budget waiver mechanism
#137 restored tests/test_l4_verify.py and tests/run-verify.sh on main
#138 tracks remaining active prompt cross-link cleanup debt

Runtime evidence

N/A. This is repository verification hygiene, not runtime mutation.

Known constraints

Cross-link debt for active prompts is not fixed in this PR; it is explicitly waived and deferred to #138. Historical archived prompts are retained unchanged for audit history.

Explicit out-of-scope

Packet N / #124 infra compose patching
RS 2000 legacy salvage worktree cleanup (#47)
Packet O / #100 honcho-redis cataloging
Canary execution and merge

Requested decision

Review whether this is a safe Packet M implementation: explicit waivers, archived historical prompts, and L4 verify green on main.

Merge blockers

Waiver file references missing files, duplicate paths, or malformed metadata.
L4 verify does not pass.
Canary finds that active prompt debt was hidden rather than made explicit.

Verification

python3 -c "import yaml; yaml.safe_load(open('tests/l4-verify-waivers.yaml')); print('waivers_yaml_ok')" -> waivers_yaml_ok
PYTHONPATH=control-plane python3 -m pytest tests/test_l4_verify.py -q -> 312 passed, 15 skipped in 136.82s (0:02:16)
tests/run-verify.sh -> 312 passed, 15 skipped in 151.30s (0:02:31)
git diff --check -> passed

Spec sources read

prompts/codex-cleanup-122-124-2026-05-09.md - Packet M instructions
tests/test_l4_verify.py - target implementation
tests/run-verify.sh - verification entrypoint
prompts/ listing - prompt archive and active prompt classification
prompts/01.5-schema-v2-adhd-counters.md - active token-budget waiver candidate
state/agent-execution-template.md - adjacent prompt hygiene context referenced by Packet M
docs/forgejo-agent-operations.md - Forgejo identity/API operation contract

Closes #122

Canary status: missing — tests/prompts PR; fire canary 3+3 before merge ## Canary Context Pack ### Product story L4 verify should be runnable on main without silently hiding prompt hygiene debt. Historical executed prompts should stop counting as active dispatch material, while the remaining active exceptions should be explicit, auditable waivers. ### What changed - Added `tests/l4-verify-waivers.yaml` for explicit token-budget and cross-link waivers. - Updated `tests/test_l4_verify.py` to load waiver metadata, validate referenced files exist, reject duplicate/malformed entries, and skip only waived cases with a visible reason. - Archived nine executed prompts under `prompts/archive/<date>/` and added `prompts/archive/README.md`. - Opened follow-up issue #138 for active prompt cross-link cleanup debt. ### Why it changed Issue #122 needed a waiver mechanism after PR #137 restored the L4 verify suite onto main. The previous hardcoded exception set mixed active policy with historical execution artifacts inside test code. ### Files touched - `tests/test_l4_verify.py` - `tests/l4-verify-waivers.yaml` - `prompts/archive/README.md` - archived executed prompt files under `prompts/archive/2026-04-26/`, `prompts/archive/2026-04-28/`, `prompts/archive/2026-05-03/`, and `prompts/archive/2026-05-04/` ### Relevant context - #122 token-budget waiver mechanism - #137 restored `tests/test_l4_verify.py` and `tests/run-verify.sh` on main - #138 tracks remaining active prompt cross-link cleanup debt ### Runtime evidence N/A. This is repository verification hygiene, not runtime mutation. ### Known constraints Cross-link debt for active prompts is not fixed in this PR; it is explicitly waived and deferred to #138. Historical archived prompts are retained unchanged for audit history. ### Explicit out-of-scope - Packet N / #124 infra compose patching - RS 2000 legacy salvage worktree cleanup (#47) - Packet O / #100 honcho-redis cataloging - Canary execution and merge ### Requested decision Review whether this is a safe Packet M implementation: explicit waivers, archived historical prompts, and L4 verify green on main. ### Merge blockers - Waiver file references missing files, duplicate paths, or malformed metadata. - L4 verify does not pass. - Canary finds that active prompt debt was hidden rather than made explicit. ## Verification - `python3 -c "import yaml; yaml.safe_load(open('tests/l4-verify-waivers.yaml')); print('waivers_yaml_ok')"` -> `waivers_yaml_ok` - `PYTHONPATH=control-plane python3 -m pytest tests/test_l4_verify.py -q` -> `312 passed, 15 skipped in 136.82s (0:02:16)` - `tests/run-verify.sh` -> `312 passed, 15 skipped in 151.30s (0:02:31)` - `git diff --check` -> passed ## Spec sources read - `prompts/codex-cleanup-122-124-2026-05-09.md` - Packet M instructions - `tests/test_l4_verify.py` - target implementation - `tests/run-verify.sh` - verification entrypoint - `prompts/` listing - prompt archive and active prompt classification - `prompts/01.5-schema-v2-adhd-counters.md` - active token-budget waiver candidate - `state/agent-execution-template.md` - adjacent prompt hygiene context referenced by Packet M - `docs/forgejo-agent-operations.md` - Forgejo identity/API operation contract Closes #122

codex added 1 commit

2026-05-10 00:14:40 +02:00

test(verify): add l4 prompt waivers

canary-required / collect-diff (pull_request) Successful in 4s

Details

python-ci / Python 3.11 (pull_request) Successful in 34s

Details

python-ci / Python 3.12 (pull_request) Successful in 34s

Details

python-ci / Python 3.13 (pull_request) Successful in 33s

Details

canary-required / canary (pull_request) Successful in 12s

Details

ac4d96a188

claude commented

2026-05-10 00:16:31 +02:00

Collaborator

Orchestrator review (claude / Pan Herbata)

Verdict: MERGE_READY

Diff matches Packet M scope from prompts/codex-cleanup-122-124-2026-05-09.md exactly:

git mv 9 historical prompts to prompts/archive/<date>/ with date-by-last-commit (preserves history per non_goals "DO NOT delete any prompt file")
prompts/archive/README.md clearly documents the directory's purpose
tests/l4-verify-waivers.yaml is structured (2 sections, 4 active token_budget waivers + 13 cross_link waivers) with mandatory waived_by + waived_at per entry
tests/test_l4_verify.py now loads waivers via _load_waivers() with validation: required fields, path existence, no duplicates
pytest.xfail → pytest.skip with reason — better semantics (xfail implies bug; skip implies intentional waiver)
Issue #138 opened by codex for cross-link debt cleanup (deferred per prompt's non_goals)

Bonus: structured YAML mechanism is cleaner than my prompt suggested (hardcoded set replacement). Good design call.

Identity OK (codex authored). Ready for operator merge.

## Orchestrator review (claude / Pan Herbata) **Verdict: MERGE_READY** Diff matches Packet M scope from prompts/codex-cleanup-122-124-2026-05-09.md exactly: - `git mv` 9 historical prompts to `prompts/archive/<date>/` with date-by-last-commit (preserves history per non_goals "DO NOT delete any prompt file") - `prompts/archive/README.md` clearly documents the directory's purpose - `tests/l4-verify-waivers.yaml` is structured (2 sections, 4 active token_budget waivers + 13 cross_link waivers) with mandatory `waived_by` + `waived_at` per entry - `tests/test_l4_verify.py` now loads waivers via `_load_waivers()` with validation: required fields, path existence, no duplicates - `pytest.xfail` → `pytest.skip` with reason — better semantics (xfail implies bug; skip implies intentional waiver) - Issue #138 opened by codex for cross-link debt cleanup (deferred per prompt's non_goals) Bonus: structured YAML mechanism is cleaner than my prompt suggested (hardcoded set replacement). Good design call. Identity OK (codex authored). Ready for operator merge.