fix(charter): §3 — clarify ordinary charter edits classification (canary #2 follow-up) #22

Merged
pdurlej merged 1 commit from claude/orders/order-f-2-followup-charter-edit-classification into main 2026-05-02 09:21:37 +02:00
Collaborator

Summary

Addresses canary ζ #2 codex tech finding (medium risk) on PR #17 post-merge.

What canary #2 found

"Impact-size rule leaves some charter edits unclassified — Small excludes any charter touch, Medium only includes 'charter sub-rule add', and Large does not cover ordinary charter edits."

Codex was right. Under previous wording, a typo fix in charter had no tier mapping (excluded from Small, didn't match Medium "sub-rule add", not Large).

Fix

3 minimal wording adjustments to §3 review-by-impact:

Tier Before After
Small "no charter touch" "no charter sub-rule add or substantive prose change" + explicit "ordinary charter edits ≤30 LOC are Small" qualifier
Medium "charter sub-rule add" "OR substantive charter prose rewrite" added
Large (no charter clause) "OR cross-section charter restructure" added
Boundary note (existed) extended with charter-tier-mapping completeness clause

Net diff: +4 / -4 LOC. Same total length, more precise wording.

Scope (per amended §3)

This PR is Small: ≤30 LOC charter edit (4 lines changed), single-file, clarification of existing rule (not new sub-rule, not substantive policy change). Pre-authorized as PR #17 follow-up fix per operator's 2026-05-02 ~03:08 CEST message: "z powodu zakresu będziesz mógł sam wypchnąć".

This is also the first test of the amended §3 rule itself (recursive: amending §3 with §3 amended).

Other canary #2 dissents (NOT in this PR)

  • product-glm BLOCKER "Bootstrap paradox": moot post-merge (decision-log entry rather than code fix)
  • product-glm risk "small-PR self-classification can bypass safety net": already mitigated by ensemble re-classification clause in §3 ("may re-classify or reject with 'wrong size declared'")

Co-authors

  • codex tech reviewer (canary ζ #2 finding, 2026-05-02 ~03:09 CEST)
  • Claude Opus 4.7 (1M context)
## Summary Addresses canary ζ #2 codex tech finding (medium risk) on PR #17 post-merge. ## What canary #2 found > "Impact-size rule leaves some charter edits unclassified — Small excludes any charter touch, Medium only includes 'charter sub-rule add', and Large does not cover ordinary charter edits." Codex was right. Under previous wording, a typo fix in charter had no tier mapping (excluded from Small, didn't match Medium "sub-rule add", not Large). ## Fix 3 minimal wording adjustments to §3 review-by-impact: | Tier | Before | After | |---|---|---| | Small | "no charter touch" | "no charter sub-rule add or substantive prose change" + explicit "ordinary charter edits ≤30 LOC are Small" qualifier | | Medium | "charter sub-rule add" | "OR substantive charter prose rewrite" added | | Large | (no charter clause) | "OR cross-section charter restructure" added | | Boundary note | (existed) | extended with charter-tier-mapping completeness clause | Net diff: **+4 / -4 LOC**. Same total length, more precise wording. ## Scope (per amended §3) This PR is **Small**: ≤30 LOC charter edit (4 lines changed), single-file, **clarification of existing rule** (not new sub-rule, not substantive policy change). Pre-authorized as PR #17 follow-up fix per operator's 2026-05-02 ~03:08 CEST message: "z powodu zakresu będziesz mógł sam wypchnąć". This is also **the first test of the amended §3 rule itself** (recursive: amending §3 with §3 amended). ## Other canary #2 dissents (NOT in this PR) - product-glm BLOCKER "Bootstrap paradox": moot post-merge (decision-log entry rather than code fix) - product-glm risk "small-PR self-classification can bypass safety net": already mitigated by ensemble re-classification clause in §3 ("may re-classify or reject with 'wrong size declared'") ## Co-authors - codex tech reviewer (canary ζ #2 finding, 2026-05-02 ~03:09 CEST) - Claude Opus 4.7 (1M context)
Per canary ζ #2 codex tech finding (medium risk) on PR #17 post-merge:

> "Impact-size rule leaves some charter edits unclassified — Small excludes
> any charter touch, Medium only includes 'charter sub-rule add', and Large
> does not cover ordinary charter edits."

Codex correctly identified that ordinary charter edits (typo fixes, formatting,
clarifications, link repairs) had no tier mapping under previous wording.

Fix:

1. Small: changed "no charter touch" → "no charter sub-rule add or substantive
   prose change". Added explicit qualifier: ordinary charter edits ≤30 LOC are Small.

2. Medium: added "OR substantive charter prose rewrite" — distinguishes from
   sub-rule add but covers prose-level changes affecting policy interpretation.

3. Large: added "OR cross-section charter restructure" — for the rare large
   reorganization case.

4. Boundary determinism note extended: clarifies that the ordinary-charter-edit
   Small qualifier ensures every charter touch maps to exactly one tier.

Per charter §3 review-by-impact (NEW disjoint tiers): this PR itself is **Small**
— ≤30 LOC charter edit, single-file, clarification of existing rule (not new
sub-rule, not substantive policy change). Pre-authorized as PR #17 follow-up
fix per operator's 2026-05-02 ~03:08 CEST message.

Net diff: +3 / -3 LOC. Same total length, more precise wording.

Addresses 1 of 3 canary #2 dissent risks. Other 2 are non-actionable
(bootstrap paradox = moot post-merge; small-PR self-classification bypass =
already mitigated by ensemble re-classification clause in §3).

Co-authored-by: codex tech reviewer (canary ζ #2, finding)
Co-authored-by: Claude Opus 4.7 (1M context)
Owner

ok to merge @claude

i can’t do it from my mobile (i don’t know why)

ok to merge @claude i can’t do it from my mobile (i don’t know why)
pdurlej approved these changes 2026-05-02 09:10:56 +02:00
Dismissed
pdurlej approved these changes 2026-05-02 09:11:03 +02:00
Dismissed
pdurlej approved these changes 2026-05-02 09:11:10 +02:00
Sign in to join this conversation.
No reviewers
No labels
W6d-automerge-calibration
agent/claude-code
agent/codex
agent/hermes
agent/iskra
agent/ollama
agent/patchwarden
automerge-candidate
class/security-sensitive
cutover-gate
dependency/blocked
dependency/blocks-others
dependency/cross-repo
dependency/needs-confirmation
domain:agents
domain:ci
domain:docs
domain:forgejo
domain:infra
domain:memory
domain:runtime
domain:signal
domain:ux
flow/architecture
flow/blocked
flow/deployed
flow/done
flow/implementation
flow/intake
flow/maintained
flow/observed
flow/ready
flow/refining
flow/retired
flow/review
iterating
judge/codex-candidate
judge/hermes-candidate
judge/low-confidence
judge/needs-refinement
judge/operator-needed
judge/p0
judge/p1
judge/p2
judge/p3
judge/park
judge/patchwarden-candidate
judge/stale-priority
kind/adr
kind/bug
kind/chore
kind/feature
kind/infra
kind/ops
kind/refactor
kind/research
large-impact
merge/auto
merge/manual
merge/manual-dependency-conflict
merge/manual-failing-tests
merge/manual-merge-conflict
merge/manual-missing-review
merge/manual-operator-preference
merge/manual-red-zone
merge/manual-security-sensitive
merge/manual-unclear-scope
merge/manual-unknown
meta
mode:operator-only
mode:patchwarden-iskra-approved
mode:safe-auto
needs-operator-decision
needs-triage
not-ready
observed/erroring
observed/needs-followup
observed/pending
observed/retire-candidate
observed/unused
observed/used
operator-emotional
owner-attention
phase/02
phase/03
priority:p0
priority:p1
priority:p2
priority:p3
proposed
ready-for-agent
ready-for-operator
recovery
review:claude-reviewed
review:codex-reviewed
review:dziadek-reviewed
review:needs-human
risk/exposure
risk/process
risk/product
risk/runtime
safety:external-write
safety:no-prod-mutation
safety:prod-impact
safety:secret-touch
size/large
size/medium
size/small
size/tiny
size/unknown
source/adr
source/agent-generated
source/manual
source/operator-chat
source/voice-note
status:blocked
status:codex-ready
status:merged:pending-evidence
status:needs-evidence
status:operator-needed
status:parked
tier/full
tier/lite
tier/stacked
tier:0-platform-substrate
tier:1-iskra-value-layer
tier:2-tools-products-modules
type:bug
type:chore
type:docs
type:feat
type:policy
type:research
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pdurlej/platform!22
No description provided.