fix(identity): align stale charter §4 refs to §3 identity-isolation (canary #2 bonus) #28

Merged

pdurlej merged 1 commit from claude/orders/order-c-followup-stale-§4-refs into main

2026-05-02 23:37:52 +02:00

claude commented

2026-05-02 11:13:07 +02:00

Collaborator

Summary

Closes Dispatch's "bonus finding follow-up" from canary v2 on PR #26.

Tech-claude reviewer caught stale charter §4 references in identity code that the charter-side fixes (PR #22 + PR #26) didn't reach. Test file even pinned the stale string with assert "charter §4" in msg (line 210) — making it a hard regression block until aligned.

Edits

File	Line(s)	Change
`codex.py`	26	`charter §4 v2` → `charter §3 identity-isolation v2` (docstring)
`codex.py`	30	`charter §4 intent` → `charter §3 identity-isolation intent`
`codex.py`	208	`charter §4 v2` → `charter §3 identity-isolation v2`
`codex.py`	221	`charter §4 v2` → `charter §3 identity-isolation v2` (exception msg)
`test_codex_askpass.py`	65	comment update
`test_codex_askpass.py`	191	section comment update
`test_codex_askpass.py`	197	docstring update
`test_codex_askpass.py`	210	`assert "charter §4" in msg` → `assert "charter §3" in msg`

Verification

grep -c '§4' on both files: 0 (was 4 each)
pytest: 13/13 PASSED in test_codex_askpass.py

Future-review checklist item

When charter section numbers change, grep tests for hardcoded section assertions. The test on line 210 was a textbook "asserts on stale external reference" trap. Could codify in state/CLAUDE_SELF_INSTRUCTIONS.md §3 (consistency anchors) as a new rule.

Scope (per charter §3)

Small impact: code-level fix, single concern, +8 / -8 LOC, no behavior change (docstrings + comments + 1 test assertion). Pre-auth A applies → push directly.

Co-authors

Dispatch (Claude Opus 4.6, canary v2 surfaced this via tech-claude reviewer)
Claude Opus 4.7 (1M context, code fix + test verification)

## Summary Closes Dispatch's "bonus finding follow-up" from canary v2 on PR #26. Tech-claude reviewer caught stale `charter §4` references in identity code that the charter-side fixes (PR #22 + PR #26) didn't reach. Test file even **pinned the stale string with `assert "charter §4" in msg`** (line 210) — making it a hard regression block until aligned. ## Edits | File | Line(s) | Change | |---|---|---| | `codex.py` | 26 | `charter §4 v2` → `charter §3 identity-isolation v2` (docstring) | | `codex.py` | 30 | `charter §4 intent` → `charter §3 identity-isolation intent` | | `codex.py` | 208 | `charter §4 v2` → `charter §3 identity-isolation v2` | | `codex.py` | 221 | `charter §4 v2` → `charter §3 identity-isolation v2` (exception msg) | | `test_codex_askpass.py` | 65 | comment update | | `test_codex_askpass.py` | 191 | section comment update | | `test_codex_askpass.py` | 197 | docstring update | | `test_codex_askpass.py` | 210 | **`assert "charter §4" in msg` → `assert "charter §3" in msg`** | ## Verification - `grep -c '§4'` on both files: **0** (was 4 each) - pytest: **13/13 PASSED** in `test_codex_askpass.py` ## Future-review checklist item When charter section numbers change, **grep tests for hardcoded section assertions**. The test on line 210 was a textbook "asserts on stale external reference" trap. Could codify in `state/CLAUDE_SELF_INSTRUCTIONS.md §3 (consistency anchors)` as a new rule. ## Scope (per charter §3) **Small impact**: code-level fix, single concern, +8 / -8 LOC, no behavior change (docstrings + comments + 1 test assertion). Pre-auth A applies → push directly. ## Co-authors - Dispatch (Claude Opus 4.6, canary v2 surfaced this via tech-claude reviewer) - Claude Opus 4.7 (1M context, code fix + test verification)

claude added the

ready-for-operator

label

2026-05-02 11:13:07 +02:00

pdurlej was assigned by claude

2026-05-02 11:13:07 +02:00

claude added 10 commits

2026-05-02 11:13:07 +02:00

feat(phase02): add public_reason to umami (Phase 02 §internet_exposed compliance) 822bdd1c8e

feat(phase02): add public_reason to uptime-kuma (Phase 02 §internet_exposed compliance) fe37fc47a3

feat(phase02): add public_reason to karakeep (Phase 02 §internet_exposed compliance) 9cb098412e

feat(phase02): add public_reason to forgejo (Phase 02 §internet_exposed compliance) d930993c00

feat(phase02): add public_reason to dashboard (Phase 02 §internet_exposed compliance) b9a62a1c42

fix(phase02): sharpen karakeep public_reason (canary-27 product-gpt finding) e376d7e9eb

fix(phase02): sharpen umami public_reason (canary-27 product-gpt finding) 78d4d55ee4

fix(phase02): sharpen karakeep public_reason (canary-27 finding) 3858871df2

fix(phase02): sharpen umami public_reason (canary-27 finding) c275e25ec9

fix(identity): align stale charter §4 refs to §3 identity-isolation (canary #2 bonus follow-up) c51fd5faae

Per Dispatch's canary v2 report on PR #26 (now merged): tech-claude reviewer
flagged stale `charter §4` references in identity code that were not addressed
by the charter doc fixes (PR #22 + #26 amended §3, but code didn't follow).

References fixed (8 total):

control-plane/platformctl/identity/codex.py (4):
- Line 26: `charter §4 v2` → `charter §3 identity-isolation v2` (WorktreeIsolationViolation docstring)
- Line 30: `charter §4 intent` → `charter §3 identity-isolation intent` (rationale text)
- Line 208: `charter §4 v2` → `charter §3 identity-isolation v2` (setup_worktree_git_config docstring)
- Line 221: `charter §4 v2` → `charter §3 identity-isolation v2` (raised exception message)

control-plane/platformctl/tests/test_codex_askpass.py (4):
- Line 65: comment update
- Line 191: section comment update
- Line 197: docstring update
- Line 210: **`assert "charter §4" in msg` → `assert "charter §3" in msg`** (was pinning the stale string!)

Verification:
- `grep -c '§4' control-plane/platformctl/identity/codex.py` → 0 (was 4)
- `grep -c '§4' control-plane/platformctl/tests/test_codex_askpass.py` → 0 (was 4)
- pytest test_codex_askpass.py: **13/13 PASSED**

Per charter §3 (PR #22 amended): code-level fix, single concern, ≤30 LOC,
docstring/comment changes + 1 test assertion → small impact. Pre-auth A applies
(operator instruction "z powodu zakresu będziesz mógł sam wypchnąć").

Bonus: canary v2 caught this because the test pinned the OLD string with
`assert "charter §4" in msg` — a textbook example of "test asserts on stale
external reference". Future review-checklist item: when changing charter
section numbers, grep tests for hardcoded section assertions.

Closes Dispatch's "follow-up PR" item from OPERATOR_INBOX 14:26Z entry.

Co-authored-by: Dispatch (Claude Opus 4.6, canary finder via tech-claude reviewer)
Co-authored-by: Claude Opus 4.7 (1M context, code fix + test verification)

pdurlej removed their assignment

2026-05-02 23:37:02 +02:00

pdurlej merged commit 44d6bec384 into main

2026-05-02 23:37:52 +02:00

pdurlej referenced this pull request from a commit

2026-05-02 23:37:52 +02:00

Merge pull request 'fix(identity): align stale charter §4 refs to §3 identity-isolation (canary #2 bonus)' (#28) from claude/orders/order-c-followup-stale-§4-refs into main

claude referenced this pull request

2026-05-03 00:42:13 +02:00

feat(phase02): mirotalk-admin — audit + freeze + import + release + acknowledged_risks #30

pdurlej referenced this pull request

2026-05-05 02:08:26 +02:00