docs(process): add security-sensitive work lane #82

Merged

pdurlej merged 2 commits from codex/process/security-sensitive-lane into main 2026-05-05 23:24:02 +02:00

Conversation 1 Commits 2 Files changed 3 +79

codex commented 2026-05-05 08:43:23 +02:00

Collaborator

Copy link

Canary status: wait-mode-escalation — current SHA ad24eee4b41c14d38c43ca53c4113c5d05c95bb4 reviewed with PR body; 4/6 OK, Claude CLI reviewers failed

Canary Context Pack

Product story

Security-sensitive platform work should not be optimized for speed. When work touches secrets, identity, auth, SSH, exposure, CI tokens, or trust boundaries, extra review friction protects the operator and the platform.

What changed

• Added a Charter rule for the security-sensitive work lane.
• Added AGENTS.md routing rules for class/security-sensitive.
• Added proactive label protocol: the author should apply it, any reviewer may add it, and when in doubt we default into the lane.
• Clarified sacred-path rules remain owner-only/break-glass; this lane does not authorize sacred runtime mutations.
• Added examples contrasting ordinary small docs with small security-sensitive changes.
• Added an atomic issue template checkbox for the class of service.
• Created Forgejo label class/security-sensitive via codex identity and applied it to this issue/PR plus the first split issue/PR.

Why it changed

PR #80 showed that access-plane hardening can look locally correct while still carrying security review concerns. Operator ruling: more friction here is a feature. This PR makes that rule explicit for future agents.

Files touched

• PLATFORM_CHARTER.md
• AGENTS.md
• .forgejo/issue_template/atomic_task.md

Relevant context

• Operator ruling in Codex thread, 2026-05-05.
• Superseded PR #80 split/rewrite decision.
• AGENTS.md PR size classes and risk taxonomy.
• Charter learning patterns.

Runtime evidence

• Docs/process-only change.
• git diff --check -> pass.
• Forgejo label class/security-sensitive exists and was created via codex identity.
• Applied label to #81/#82/#83/#84 via Forgejo API.
• After branch update to current main, canary was rerun with --pr-description-file: 4/6 reviewers OK; tech-claude and product-claude failed via Claude CLI exit 1.

Known constraints

This adds process policy and label routing; it does not enforce the lane mechanically in CI yet. Mechanical enforcement is tracked in #86.

Explicit out-of-scope

• CI enforcement for label/routing; tracked as #86.
• Rewriting current #79 implementation splits.
• Changing canary runner behavior.

Requested decision

Wait-mode escalation: operator/orchestrator can retry Claude reviewers when provider is stable, or accept prior full 6/6 approval on the pre-main-update SHA plus current 4/6 OK evidence.

Merge blockers

• Rule is too vague to apply.
• Rule conflicts with existing canary/PR-size policy.
• Rule accidentally permits security work to bypass review.
• Rule appears to authorize direct sacred-path mutation.

Spec sources read

• PLATFORM_CHARTER.md Learning patterns / review policy.
• AGENTS.md PR size classes and risk taxonomy.
• .forgejo/issue_template/atomic_task.md risk class template.
• Operator Codex thread context from 2026-05-05, for the explicit ruling.

Closes #81

Canary status: wait-mode-escalation — current SHA `ad24eee4b41c14d38c43ca53c4113c5d05c95bb4` reviewed with PR body; 4/6 OK, Claude CLI reviewers failed ## Canary Context Pack ### Product story Security-sensitive platform work should not be optimized for speed. When work touches secrets, identity, auth, SSH, exposure, CI tokens, or trust boundaries, extra review friction protects the operator and the platform. ### What changed - Added a Charter rule for the security-sensitive work lane. - Added AGENTS.md routing rules for `class/security-sensitive`. - Added proactive label protocol: the author should apply it, any reviewer may add it, and when in doubt we default into the lane. - Clarified sacred-path rules remain owner-only/break-glass; this lane does not authorize sacred runtime mutations. - Added examples contrasting ordinary small docs with small security-sensitive changes. - Added an atomic issue template checkbox for the class of service. - Created Forgejo label `class/security-sensitive` via codex identity and applied it to this issue/PR plus the first split issue/PR. ### Why it changed PR #80 showed that access-plane hardening can look locally correct while still carrying security review concerns. Operator ruling: more friction here is a feature. This PR makes that rule explicit for future agents. ### Files touched - `PLATFORM_CHARTER.md` - `AGENTS.md` - `.forgejo/issue_template/atomic_task.md` ### Relevant context - Operator ruling in Codex thread, 2026-05-05. - Superseded PR #80 split/rewrite decision. - AGENTS.md PR size classes and risk taxonomy. - Charter learning patterns. ### Runtime evidence - Docs/process-only change. - `git diff --check` -> pass. - Forgejo label `class/security-sensitive` exists and was created via codex identity. - Applied label to #81/#82/#83/#84 via Forgejo API. - After branch update to current main, canary was rerun with `--pr-description-file`: 4/6 reviewers OK; `tech-claude` and `product-claude` failed via Claude CLI exit 1. ### Known constraints This adds process policy and label routing; it does not enforce the lane mechanically in CI yet. Mechanical enforcement is tracked in #86. ### Explicit out-of-scope - CI enforcement for label/routing; tracked as #86. - Rewriting current #79 implementation splits. - Changing canary runner behavior. ### Requested decision Wait-mode escalation: operator/orchestrator can retry Claude reviewers when provider is stable, or accept prior full 6/6 approval on the pre-main-update SHA plus current 4/6 OK evidence. ### Merge blockers - Rule is too vague to apply. - Rule conflicts with existing canary/PR-size policy. - Rule accidentally permits security work to bypass review. - Rule appears to authorize direct sacred-path mutation. ## Spec sources read - `PLATFORM_CHARTER.md` Learning patterns / review policy. - `AGENTS.md` PR size classes and risk taxonomy. - `.forgejo/issue_template/atomic_task.md` risk class template. - Operator Codex thread context from 2026-05-05, for the explicit ruling. Closes #81

codex added 1 commit 2026-05-05 08:43:23 +02:00

docs(process): add security-sensitive work lane 5e78490977

codex force-pushed codex/process/security-sensitive-lane from 5e78490977 to 54f6f2fec1 2026-05-05 08:45:12 +02:00 Compare

codex force-pushed codex/process/security-sensitive-lane from 54f6f2fec1 to 3f6945864f 2026-05-05 08:48:07 +02:00 Compare

codex added the

class/security-sensitive

label 2026-05-05 08:48:30 +02:00

codex referenced this pull request 2026-05-05 09:10:12 +02:00

fix(canary): include PR body in reviewer context #85

pdurlej added 1 commit 2026-05-05 09:27:24 +02:00

Merge branch 'main' into codex/process/security-sensitive-lane ad24eee4b4

codex referenced this pull request 2026-05-05 09:32:07 +02:00

fix(process): enforce security-sensitive label routing #86

codex commented 2026-05-05 09:32:37 +02:00

Author

Collaborator

Copy link

Update after branch refresh

• Branch #82 is now at ad24eee4b41c14d38c43ca53c4113c5d05c95bb4, merged with current main.
• Reran canary with --pr-description-file, so reviewer context included the PR body.
• Result: wait-mode-escalation, not code/process defer: 4/6 reviewers OK; tech-claude and product-claude failed with Claude CLI exit 1.
• The previous false PR description: none finding disappeared for successful reviewers.
• Follow-up #86 tracks mechanical enforcement for the class/security-sensitive label.

Update after branch refresh - Branch #82 is now at `ad24eee4b41c14d38c43ca53c4113c5d05c95bb4`, merged with current `main`. - Reran canary with `--pr-description-file`, so reviewer context included the PR body. - Result: `wait-mode-escalation`, not code/process defer: 4/6 reviewers OK; `tech-claude` and `product-claude` failed with Claude CLI exit 1. - The previous false `PR description: none` finding disappeared for successful reviewers. - Follow-up #86 tracks mechanical enforcement for the `class/security-sensitive` label.

pdurlej merged commit f5a778fed6 into main 2026-05-05 23:24:02 +02:00

pdurlej referenced this pull request from a commit 2026-05-05 23:24:02 +02:00

Merge pull request 'docs(process): add security-sensitive work lane' (#82) from codex/process/security-sensitive-lane into main

codex referenced this pull request 2026-05-05 23:33:11 +02:00

fix(agent-access): harden ssh-agent startup cleanup #84

codex referenced this pull request 2026-05-05 23:43:35 +02:00

test(agent-access): cover signal cleanup path #90

codex referenced this pull request 2026-05-05 23:58:00 +02:00

feat(agent-access): list non-secret ssh-agent sessions #93

codex referenced this pull request 2026-05-06 00:24:15 +02:00

feat(agent-access): prune stopped and expired sessions #96

codex referenced this pull request 2026-05-06 00:53:58 +02:00

feat(agent-access): prune stopped and expired sessions #108

codex referenced this pull request 2026-05-06 01:15:02 +02:00

fix(agent-access): tighten stop session id validation #110

claude referenced this pull request 2026-05-17 17:27:24 +02:00

docs(specs): prebuild for #243 branch protection main with base-is-main guard #330

claude referenced this pull request 2026-05-17 21:29:20 +02:00

docs(specs): secrets-pipeline-foundation-v0 prebuild (#237) #349

codex referenced this pull request from a commit 2026-05-17 21:30:16 +02:00

docs(specs): bug prebuild for #85 canary PR body in reviewer context

claude referenced this pull request from a commit 2026-05-18 08:16:30 +02:00

docs(specs): #85 bug prebuild — canary PR body in reviewer context

claude referenced this pull request 2026-05-18 08:16:51 +02:00

docs(specs): #85 bug prebuild — canary PR body in reviewer context #363

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

W6d-automerge-calibration

  

agent/claude-code

Vistula actor: Claude Code.

  

agent/codex

Vistula actor: Codex.

  

agent/hermes

Vistula actor: Hermes Upstream.

  

agent/iskra

Vistula actor: Iskra.

  

agent/ollama

Vistula actor: Ollama or compatible model.

  

agent/patchwarden

Vistula actor: Patchwarden.

  

automerge-candidate

Candidate for narrow W6d autonomous merge readiness pilot

  

class/security-sensitive

Security-sensitive class of service: smallest coherent PRs and full canary

  

cutover-gate

blocks production declare / final RS2000 replacement

  

dependency/blocked

Vistula dependency state: blocked.

  

dependency/blocks-others

Vistula dependency state: blocks other work.

  

dependency/cross-repo

Vistula dependency scope: cross-repository.

  

dependency/needs-confirmation

Vistula dependency state: needs confirmation.

  

domain:agents

Agent identity, delegation, subagents, routing, or workflows.

  

domain:ci

CI, checks, Actions, runners, or release automation.

  

domain:docs

Documentation, packets, practices, or source-of-truth text.

  

domain:forgejo

Forgejo issues, PRs, labels, repo settings, or identity.

  

domain:infra

Infrastructure, storage, backup, DNS, network, or host substrate.

  

domain:memory

Memory, recall, write gates, salience, or Honcho-adjacent behavior.

  

domain:runtime

Runtime services, deploys, daemons, timers, or live behavior.

  

domain:signal

Signal UX, delivery, context, or outbound behavior.

  

domain:ux

Product UX, operator experience, or conversation ergonomics.

  

flow/architecture

Vistula lifecycle: architecture phase in progress.

  

flow/blocked

Vistula lifecycle: blocked on dependency or decision.

  

flow/deployed

Vistula lifecycle: deployed to runtime where applicable.

  

flow/done

Vistula lifecycle: work merged or otherwise done.

  

flow/implementation

Vistula lifecycle: implementation phase in progress.

  

flow/intake

Vistula lifecycle: incoming signal not refined yet.

  

flow/maintained

Vistula lifecycle: maintained/steady state.

  

flow/observed

Vistula lifecycle: observed after delivery.

  

flow/ready

Vistula lifecycle: ready for architecture or implementation.

  

flow/refining

Vistula lifecycle: Hermes/spec refinement in progress.

  

flow/retired

Vistula lifecycle: retired or intentionally closed.

  

flow/review

Vistula lifecycle: review phase in progress.

  

iterating

Orchestrator/Codex actively amending in response to review — operator can ignore until resolved

  

judge/codex-candidate

Candidate for Codex implementation.

  

judge/hermes-candidate

Candidate for Hermes discovery/research.

  

judge/low-confidence

Judgment confidence is low.

  

judge/needs-refinement

Needs clearer evidence or scope.

  

judge/operator-needed

Needs Piotr decision or input.

  

judge/p0

Urgent, operator attention or unblock now.

  

judge/p1

High value, schedule soon.

  

judge/p2

Useful, normal queue.

  

judge/p3

Low priority, keep but do not chase.

  

judge/park

Parked from current attention.

  

judge/patchwarden-candidate

Needs Patchwarden merge-safety attention.

  

judge/stale-priority

Existing priority judgment appears stale.

  

kind/adr

Vistula work kind: architecture decision record.

  

kind/bug

Vistula work kind: bug fix.

  

kind/chore

Vistula work kind: chore.

  

kind/feature

Vistula work kind: feature.

  

kind/infra

Vistula work kind: infrastructure.

  

kind/ops

Vistula work kind: operations.

  

kind/refactor

Vistula work kind: refactor.

  

kind/research

Vistula work kind: research/discovery.

  

large-impact

Per charter §3 review-by-impact: large impact (≥300 LOC OR new module OR identity/secret change OR architectural pivot) — Oracle pre-review recommended

  

merge/auto

Vistula merge mode: automated merge.

  

merge/manual

Vistula merge mode: manual merge.

  

merge/manual-dependency-conflict

Manual merge reason: dependency conflict.

  

merge/manual-failing-tests

Manual merge reason: failing tests.

  

merge/manual-merge-conflict

Manual merge reason: merge conflict.

  

merge/manual-missing-review

Manual merge reason: missing review.

  

merge/manual-operator-preference

Manual merge reason: operator preference.

  

merge/manual-red-zone

Manual merge reason: red-zone risk.

  

merge/manual-security-sensitive

Manual merge reason: security-sensitive work.

  

merge/manual-unclear-scope

Manual merge reason: unclear scope.

  

merge/manual-unknown

Manual merge reason: unknown.

  

meta

meta-decomposition issue; first agent decomposes into atomic children

  

mode:operator-only

Apply step requires explicit operator approval.

  

mode:patchwarden-iskra-approved

Work eligible for Patchwarden/Iskra approval inside repo policy.

  

mode:safe-auto

Low-risk work eligible for lightweight autonomous handling.

  

needs-operator-decision

PR is blocked on operator yes/no decision — fresh-Claude/Codex won't make this call alone

  

needs-triage

decomposing agent has open questions / unknowns

  

not-ready

reviewed but blocked on a precondition

  

observed/erroring

Vistula observation: erroring.

  

observed/needs-followup

Vistula observation: needs follow-up.

  

observed/pending

Vistula observation: pending.

  

observed/retire-candidate

Vistula observation: retire candidate.

  

observed/unused

Vistula observation: unused.

  

observed/used

Vistula observation: used.

  

operator-emotional

operator-emotional importance (Iskra memory etc.)

  

owner-attention

owner must decide; blocks default path

  

phase/02

Phase 02 cataloging

  

phase/03

Phase 03 control plane (platformctl)

  

priority:p0

Immediate safety, uptime, data, or operator-blocking issue.

  

priority:p1

Important active work; should be pulled soon.

  

priority:p2

Useful normal-priority work.

  

priority:p3

Opportunistic cleanup, research, or backlog work.

  

proposed

auto-generated by meta-decomposition; awaiting human review

  

ready-for-agent

reviewed and pickable; agents may claim per cookbook

  

ready-for-operator

PR is ready for operator review/merge — orchestrator finished its part

  

recovery

disaster recovery / restore semantics relevant

  

review:claude-reviewed

Reviewed by Claude-family agent.

  

review:codex-reviewed

Reviewed by Codex-family agent.

  

review:dziadek-reviewed

Reviewed by Dziadek pinch-point reviewer.

  

review:needs-human

Needs human review before merge or apply.

  

risk/exposure

incorrectly public/private/tailnet/auth/routed

  

risk/process

workflow/review/orchestration may produce bad outcomes

  

risk/product

work may have lost owner/user value

  

risk/runtime

platform may not run, recover, validate, behave reproducibly

  

safety:external-write

May write to external systems, users, rooms, repos, or services.

  

safety:no-prod-mutation

Must not mutate production or live external state.

  

safety:prod-impact

May affect production/runtime behavior.

  

safety:secret-touch

Touches secrets, credentials, auth, or secret-adjacent config.

  

size/large

Vistula size: large.

  

size/medium

Vistula size: medium.

  

size/small

Vistula size: small.

  

size/tiny

Vistula size: tiny.

  

size/unknown

Vistula size: not classified yet.

  

source/adr

Vistula source: ADR.

  

source/agent-generated

Vistula source: agent generated.

  

source/manual

Vistula source: manual entry.

  

source/operator-chat

Vistula source: operator chat.

  

source/voice-note

Vistula source: voice note.

  

status:blocked

Blocked by missing dependency, evidence, access, or operator decision.

  

status:codex-ready

Ready for a Codex implementation pass.

  

status:merged:pending-evidence

Merged but waiting for live or artifact evidence before closure.

  

status:needs-evidence

Needs proof, logs, tests, or operator-visible evidence.

  

status:operator-needed

Requires explicit operator input before safe progress.

  

status:parked

Intentionally deferred; not active campaign work.

  

tier/full

Full review tier per ADR-0007

  

tier/lite

Lite review tier per ADR-0007

  

tier/stacked

Stacked PR (base != main) escape hatch per ADR-0017. Requires consolidator-PR plan in PR body.

  

tier:0-platform-substrate

Data, secrets, backup, storage, or critical platform substrate.

  

tier:1-iskra-value-layer

Iskra/OpenClaw behavior, memory, runtime, or value-layer work.

  

tier:2-tools-products-modules

Tools, products, modules, experiments, and lower-blast-radius work.

  

type:bug

Incorrect behavior or regression.

  

type:chore

Maintenance, cleanup, metadata, or operational task.

  

type:docs

Documentation-only work.

  

type:feat

New capability or product behavior.

  

type:policy

Governance, protocol, boundary, or decision-contract change.

  

type:research

Investigation, spike, or evidence-gathering task.

No labels

W6d-automerge-calibration

agent/claude-code

agent/codex

agent/hermes

agent/iskra

agent/ollama

agent/patchwarden

automerge-candidate

class/security-sensitive

cutover-gate

dependency/blocked

dependency/blocks-others

dependency/cross-repo

dependency/needs-confirmation

domain:agents

domain:ci

domain:docs

domain:forgejo

domain:infra

domain:memory

domain:runtime

domain:signal

domain:ux

flow/architecture

flow/blocked

flow/deployed

flow/done

flow/implementation

flow/intake

flow/maintained

flow/observed

flow/ready

flow/refining

flow/retired

flow/review

iterating

judge/codex-candidate

judge/hermes-candidate

judge/low-confidence

judge/needs-refinement

judge/operator-needed

judge/p0

judge/p1

judge/p2

judge/p3

judge/park

judge/patchwarden-candidate

judge/stale-priority

kind/adr

kind/bug

kind/chore

kind/feature

kind/infra

kind/ops

kind/refactor

kind/research

large-impact

merge/auto

merge/manual

merge/manual-dependency-conflict

merge/manual-failing-tests

merge/manual-merge-conflict

merge/manual-missing-review

merge/manual-operator-preference

merge/manual-red-zone

merge/manual-security-sensitive

merge/manual-unclear-scope

merge/manual-unknown

meta

mode:operator-only

mode:patchwarden-iskra-approved

mode:safe-auto

needs-operator-decision

needs-triage

not-ready

observed/erroring

observed/needs-followup

observed/pending

observed/retire-candidate

observed/unused

observed/used

operator-emotional

owner-attention

phase/02

phase/03

priority:p0

priority:p1

priority:p2

priority:p3

proposed

ready-for-agent

ready-for-operator

recovery

review:claude-reviewed

review:codex-reviewed

review:dziadek-reviewed

review:needs-human

risk/exposure

risk/process

risk/product

risk/runtime

safety:external-write

safety:no-prod-mutation

safety:prod-impact

safety:secret-touch

size/large

size/medium

size/small

size/tiny

size/unknown

source/adr

source/agent-generated

source/manual

source/operator-chat

source/voice-note

status:blocked

status:codex-ready

status:merged:pending-evidence

status:needs-evidence

status:operator-needed

status:parked

tier/full

tier/lite

tier/stacked

tier:0-platform-substrate

tier:1-iskra-value-layer

tier:2-tools-products-modules

type:bug

type:chore

type:docs

type:feat

type:policy

type:research

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

pdurlej/platform!82

No description provided.